From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Ishizaki Kou <kou.ishizaki@toshiba.co.jp>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH] xmon consistency clean up
Date: Wed, 25 Jul 2007 16:21:38 +1000 [thread overview]
Message-ID: <1185344499.5439.307.camel@localhost.localdomain> (raw)
In-Reply-To: <200707250257.l6P2va65006958@toshiba.co.jp>
On Wed, 2007-07-25 at 11:57 +0900, Ishizaki Kou wrote:
> This patch cleans up xmon to keep consistency.
>
> In xmon, we should use console I/O functions that are named the same
> as user space stdio functions. But commit
> 4d404edce30f911004850d472e05a31efd751662 broke this consistency.
>
> Signed-off-by: Kou Ishizaki <kou.ishizaki@toshiba.co.jp>
> ---
>
> Index: linux-powerpc-git/arch/powerpc/xmon/nonstdio.c
> ===================================================================
> --- linux-powerpc-git.orig/arch/powerpc/xmon/nonstdio.c
> +++ linux-powerpc-git/arch/powerpc/xmon/nonstdio.c
> @@ -133,7 +133,7 @@ void xmon_printf(const char *format, ...
> xmon_write(xmon_outbuf, n);
> }
>
> -void xmon_puts(const char *str)
> +void xmon_fputs(const char *str)
> {
> xmon_write(str, strlen(str));
Nah, keep it xmon_puts, since it doesn't take a stream argument and
define a "puts" for use by xmon core.
Ben.
next prev parent reply other threads:[~2007-07-25 6:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-25 2:57 [PATCH] xmon consistency clean up Ishizaki Kou
2007-07-25 6:21 ` Benjamin Herrenschmidt [this message]
2007-07-25 12:13 ` Michael Ellerman
2007-07-25 14:25 ` Grant Likely
2007-07-27 6:11 ` Ishizaki Kou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1185344499.5439.307.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=kou.ishizaki@toshiba.co.jp \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).