From: David Woodhouse <dwmw2@infradead.org>
To: michael@ellerman.id.au
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] Fix ibmvscsi client for multiplatform iSeries+pSeries kernel.
Date: Thu, 26 Jul 2007 08:46:37 +0100 [thread overview]
Message-ID: <1185435997.14697.432.camel@pmac.infradead.org> (raw)
In-Reply-To: <1185413275.25216.2.camel@concordia.ozlabs.ibm.com>
On Thu, 2007-07-26 at 11:27 +1000, Michael Ellerman wrote:
> Nice that someone finally fixed this up.
>
> But I get:
>
> drivers/scsi/ibmvscsi/ibmvscsi.c:1651: error: 'FW_FEATURE_ISERIES' undeclared (first use in this function)
> drivers/scsi/ibmvscsi/ibmvscsi.c:1651: error: (Each undeclared identifier is reported only once
> drivers/scsi/ibmvscsi/ibmvscsi.c:1651: error: for each function it appears in.)
> drivers/scsi/ibmvscsi/ibmvscsi.c:1653: error: 'FW_FEATURE_VIO' undeclared (first use in this function)
>
> Missing <asm/firmware.h> ?
Hm, I wonder why it ever worked for me then...
Ah, it seems that <asm/time.h> only includes <asm/firmware.h> if
CONFIG_PPC_ISERIES. We should include <asm/firmware.h> directly from
ibmvscsi.c rather than relying on it being pulled in indirectly. I'll
send a new patch. Thanks.
--
dwmw2
next prev parent reply other threads:[~2007-07-26 7:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-25 14:41 [PATCH] Fix ibmvscsi client for multiplatform iSeries+pSeries kernel David Woodhouse
2007-07-26 1:27 ` Michael Ellerman
2007-07-26 7:46 ` David Woodhouse [this message]
2007-07-26 8:00 ` [PATCH v2] " David Woodhouse
2007-07-31 11:42 ` [PATCH v3] " David Woodhouse
2007-08-03 20:51 ` Brian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1185435997.14697.432.camel@pmac.infradead.org \
--to=dwmw2@infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=paulus@samba.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).