linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Will Schmidt <will_schmidt@vnet.ibm.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: ppc-dev <linuxppc-dev@ozlabs.org>, paulus@samba.org
Subject: Re: [PATCH] [POWERPC] iSeries: fix section mismatch warnings
Date: Thu, 26 Jul 2007 14:39:04 -0500	[thread overview]
Message-ID: <1185478744.2669.0.camel@farscape.rchland.ibm.com> (raw)
In-Reply-To: <20070726115601.7733fb96.sfr@canb.auug.org.au>

On Thu, 2007-07-26 at 11:56 +1000, Stephen Rothwell wrote:
> Hi Will,
> 
> On Wed, 25 Jul 2007 11:55:31 -0500 Will Schmidt <will_schmidt@vnet.ibm.com> wrote:
> >
> > >  	cmpwi	0,r24,0			/* Are we processor 0? */
> > > -	beq	.__start_initialization_iSeries	/* Start up the first processor */
> > > -	mfspr	r4,SPRN_CTRLF
> > > +	bne	1f
> > > +	b	.__start_initialization_iSeries	/* Start up the first processor */
> > > +1:	mfspr	r4,SPRN_CTRLF
> > >  	li	r5,CTRL_RUNLATCH	/* Turn off the run light */
> > 
> > This part isnt clicking for me.. 
> > How does changing a "beq" to a "bne" over a "b" fit into changing
> > __start_initialization_iSeries static?  
> 
> Because I moved __start_initialization_iSeries into another section, it
> ends up too far away for a conditional branch so something adds a jump
> table to the .text section and changes this branch to be via that table.
> Unfortunately, the jump table ends up at the start of the .text and ruins
> our carefully laid out kernel image.  By inverting the test I can turn
> the branch into an unconditional one which has a larger possible offse
> (effectively building the jump table manually).

Gotcha, thanks for the clarification.  :-)

-Will

> 
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev

      reply	other threads:[~2007-07-26 19:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-24 23:27 [PATCH] [POWERPC] iSeries: fix section mismatch warnings Stephen Rothwell
2007-07-25 16:55 ` Will Schmidt
2007-07-26  1:56   ` Stephen Rothwell
2007-07-26 19:39     ` Will Schmidt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1185478744.2669.0.camel@farscape.rchland.ibm.com \
    --to=will_schmidt@vnet.ibm.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).