From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e36.co.us.ibm.com (e36.co.us.ibm.com [32.97.110.154]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "e36.co.us.ibm.com", Issuer "Equifax" (verified OK)) by ozlabs.org (Postfix) with ESMTP id E5E4BDDE9D for ; Fri, 27 Jul 2007 05:39:09 +1000 (EST) Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e36.co.us.ibm.com (8.13.8/8.13.8) with ESMTP id l6QJd6NE011818 for ; Thu, 26 Jul 2007 15:39:06 -0400 Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v8.4) with ESMTP id l6QJd5qx217830 for ; Thu, 26 Jul 2007 13:39:05 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l6QJd5pO030587 for ; Thu, 26 Jul 2007 13:39:05 -0600 Subject: Re: [PATCH] [POWERPC] iSeries: fix section mismatch warnings From: Will Schmidt To: Stephen Rothwell In-Reply-To: <20070726115601.7733fb96.sfr@canb.auug.org.au> References: <20070725092735.0a5a1c52.sfr@canb.auug.org.au> <1185382531.22237.46.camel@farscape.rchland.ibm.com> <20070726115601.7733fb96.sfr@canb.auug.org.au> Content-Type: text/plain Date: Thu, 26 Jul 2007 14:39:04 -0500 Message-Id: <1185478744.2669.0.camel@farscape.rchland.ibm.com> Mime-Version: 1.0 Cc: ppc-dev , paulus@samba.org Reply-To: will_schmidt@vnet.ibm.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 2007-07-26 at 11:56 +1000, Stephen Rothwell wrote: > Hi Will, > > On Wed, 25 Jul 2007 11:55:31 -0500 Will Schmidt wrote: > > > > > cmpwi 0,r24,0 /* Are we processor 0? */ > > > - beq .__start_initialization_iSeries /* Start up the first processor */ > > > - mfspr r4,SPRN_CTRLF > > > + bne 1f > > > + b .__start_initialization_iSeries /* Start up the first processor */ > > > +1: mfspr r4,SPRN_CTRLF > > > li r5,CTRL_RUNLATCH /* Turn off the run light */ > > > > This part isnt clicking for me.. > > How does changing a "beq" to a "bne" over a "b" fit into changing > > __start_initialization_iSeries static? > > Because I moved __start_initialization_iSeries into another section, it > ends up too far away for a conditional branch so something adds a jump > table to the .text section and changes this branch to be via that table. > Unfortunately, the jump table ends up at the start of the .text and ruins > our carefully laid out kernel image. By inverting the test I can turn > the branch into an unconditional one which has a larger possible offse > (effectively building the jump table manually). Gotcha, thanks for the clarification. :-) -Will > > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@ozlabs.org > https://ozlabs.org/mailman/listinfo/linuxppc-dev