From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Michael Neuling <mikey@neuling.org>
Cc: linuxppc-dev@ozlabs.org, will_schmidt@vnet.ibm.com,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] fixes for the SLB shadow buffer
Date: Thu, 02 Aug 2007 19:14:39 +1000 [thread overview]
Message-ID: <1186046080.5495.620.camel@localhost.localdomain> (raw)
In-Reply-To: <17854.1186045405@neuling.org>
On Thu, 2007-08-02 at 19:03 +1000, Michael Neuling wrote:
> >
> > Ok, that was missing from your description :-)
>
> Sorry... so ditch the barriers?
As you like. The reason why you can ditch them is purely because you
know for sure that the only case the firmware will access those shadows
from another CPU is that one and it happens to be just right. What are
the chances that in the future, FW will do something different and
nobody will "fix" the code ?
Considering that eieios are fairly cheap and it's not a very hot code
path as far as I can tell, I'd rather keep them.
Cheers,
Ben.
next prev parent reply other threads:[~2007-08-02 9:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-01 4:56 [PATCH] fixes for the SLB shadow buffer Michael Neuling
2007-08-01 5:28 ` Paul Mackerras
2007-08-01 6:02 ` Michael Neuling
2007-08-01 21:48 ` Will Schmidt
2007-08-02 5:56 ` Michael Neuling
2007-08-02 7:31 ` Benjamin Herrenschmidt
2007-08-02 8:56 ` Michael Neuling
2007-08-02 8:58 ` Benjamin Herrenschmidt
2007-08-02 9:03 ` Michael Neuling
2007-08-02 9:14 ` Benjamin Herrenschmidt [this message]
2007-08-02 9:28 ` Michael Neuling
2007-08-03 1:55 ` Michael Neuling
2007-08-03 2:50 ` Benjamin Herrenschmidt
2007-08-01 22:33 ` Benjamin Herrenschmidt
2007-08-01 23:32 ` Michael Neuling
2007-08-02 0:05 ` Benjamin Herrenschmidt
2007-08-02 1:04 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1186046080.5495.620.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
--cc=paulus@samba.org \
--cc=will_schmidt@vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).