From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] Fix special PTE code for secondary hash bucket
Date: Fri, 03 Aug 2007 21:51:15 +1000 [thread overview]
Message-ID: <1186141875.11904.0.camel@gruick> (raw)
In-Reply-To: <18098.61003.38084.554299@cargo.ozlabs.ibm.com>
On Fri, 2007-08-03 at 18:58 +1000, Paul Mackerras wrote:
> The code for mapping special 4k pages on kernels using a 64kB base
> page size was missing the code for doing the RPN (real page number)
> manipulation when inserting the hardware PTE in the secondary hash
> bucket. It needs the same code as has already been added to the
> code that inserts the HPTE in the primary hash bucket. This adds it.
>
> Spotted by Ben Herrenschmidt.
>
> Signed-off-by: Paul Mackerras <paulus@samba.org>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
> diff --git a/arch/powerpc/mm/hash_low_64.S b/arch/powerpc/mm/hash_low_64.S
> index 4762ff7..35eabfb 100644
> --- a/arch/powerpc/mm/hash_low_64.S
> +++ b/arch/powerpc/mm/hash_low_64.S
> @@ -472,10 +472,12 @@ _GLOBAL(htab_call_hpte_insert1)
> /* Now try secondary slot */
>
> /* real page number in r5, PTE RPN value + index */
> - rldicl r5,r31,64-PTE_RPN_SHIFT,PTE_RPN_SHIFT
> + andis. r0,r31,_PAGE_4K_PFN@h
> + srdi r5,r31,PTE_RPN_SHIFT
> + bne- 3f
> sldi r5,r5,PAGE_SHIFT-HW_PAGE_SHIFT
> add r5,r5,r25
> - sldi r5,r5,HW_PAGE_SHIFT
> +3: sldi r5,r5,HW_PAGE_SHIFT
>
> /* Calculate secondary group hash */
> andc r0,r27,r28
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
next prev parent reply other threads:[~2007-08-03 11:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-03 8:58 [PATCH] Fix special PTE code for secondary hash bucket Paul Mackerras
2007-08-03 11:51 ` Benjamin Herrenschmidt [this message]
2007-08-03 19:32 ` Page faults blowing up ... [was " Linas Vepstas
2007-08-03 21:54 ` Mike Strosaker
2007-08-04 2:31 ` Benjamin Herrenschmidt
2007-08-06 19:19 ` Linas Vepstas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1186141875.11904.0.camel@gruick \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).