From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [patch 06/10] 40x decrementer fixes
Date: Sat, 04 Aug 2007 12:28:11 +1000 [thread overview]
Message-ID: <1186194491.5733.2.camel@gruick> (raw)
In-Reply-To: <46B35C07.4090806@ru.mvista.com>
On Fri, 2007-08-03 at 20:47 +0400, Sergei Shtylyov wrote:
> Josh Boyer wrote:
>
> > Allow generic_calibrate_decr to work for 40x platforms. Given that the hardware
> > behavior is identical, this also changes the set_dec function to reload the PIT
> > on 40x to match the behavior 44x currently has.
>
> Why bother doing this?! This will only warrant you imprecise decrementer
> interrupts while it should be interrupting at the precise period currently (if
> you load PIT once)...
Because that's what the kernel timekeeping code expects ? The reference
time is the timebase and it doesn't drift.
The DEC/PIT is commonly used to trigger any timing, such as what is done
for lost interrupts on some platforms. Also, with dynticks, we'll most
certainly want variable reload values as well.
So I'm very happy to have Josh change the code that way. It makes things
more consistent accross the board and removes confusion.
Ben.
next prev parent reply other threads:[~2007-08-04 2:28 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-03 16:09 [patch 00/10] 4xx patch series for 2.6.24 Josh Boyer
2007-08-03 16:09 ` [patch 01/10] Rename 4xx paths to 40x Josh Boyer
2007-08-03 16:09 ` [patch 02/10] 4xx Kconfig cleanup Josh Boyer
2007-08-04 7:45 ` David Gibson
2007-08-06 12:31 ` Josh Boyer
2007-08-07 3:06 ` David Gibson
2007-08-03 16:09 ` [patch 03/10] Rename 44x bootwrapper Josh Boyer
2007-08-06 4:36 ` David Gibson
2007-08-03 16:09 ` [patch 04/10] 4xx bootwrapper reworks Josh Boyer
2007-08-06 4:38 ` David Gibson
2007-08-06 12:36 ` Josh Boyer
2007-08-07 3:05 ` David Gibson
2007-08-07 13:10 ` Josh Boyer
2007-08-08 1:19 ` David Gibson
2007-08-03 16:09 ` [patch 05/10] 40x MMU Josh Boyer
2007-08-06 4:34 ` David Gibson
2007-08-03 16:09 ` [patch 06/10] 40x decrementer fixes Josh Boyer
2007-08-03 16:47 ` Sergei Shtylyov
2007-08-03 17:10 ` Sergei Shtylyov
2007-08-03 17:25 ` Josh Boyer
2007-08-03 17:30 ` Sergei Shtylyov
2007-08-03 17:30 ` Josh Boyer
2007-08-03 17:35 ` Sergei Shtylyov
2007-08-04 2:28 ` Benjamin Herrenschmidt
2007-08-05 14:12 ` Sergei Shtylyov
2007-08-03 17:15 ` Josh Boyer
2007-08-03 17:25 ` Sergei Shtylyov
2007-08-04 2:28 ` Benjamin Herrenschmidt [this message]
2007-08-05 14:19 ` Sergei Shtylyov
2007-08-03 16:09 ` [patch 07/10] Fix 40x build Josh Boyer
2007-08-06 4:39 ` David Gibson
2007-08-03 16:09 ` [patch 08/10] Bamboo DTS Josh Boyer
2007-08-06 4:53 ` David Gibson
2007-08-06 18:01 ` Jon Loeliger
2007-08-06 18:05 ` Josh Boyer
2007-08-07 13:11 ` Josh Boyer
2007-08-03 16:09 ` [patch 09/10] Bamboo board support Josh Boyer
2007-08-06 4:55 ` David Gibson
2007-08-03 16:09 ` [patch 10/10] Bamboo zImage wrapper Josh Boyer
2007-08-06 5:00 ` David Gibson
2007-08-06 12:39 ` Josh Boyer
2007-08-07 3:04 ` David Gibson
2007-08-07 3:04 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1186194491.5733.2.camel@gruick \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).