Trying to use Device Tree...and getting continuous interrupts from attached 88e1145

Trying to use Device Tree...and getting continuous interrupts from attached 88e1145

[Morrison, Tom]

All,

Connected to eth1 (etsec2) of my mpc8548 cpu is a 88E1145 and I=20
am trying to get the core functionality running with the device tree
paradigm - I know the sense of the 88E1145 is active-low for my=20
mpc8548 board and have it working with an older 2.6.11++ kernel. =20

I built this new kernel with the marvell driver - it seemingly=20
does all the same things we did in the 2.6.11 kernel in separate=20
spots...

Here is the appropriate parts of my device tree for this part of the
core...

>>		mdio@24520 {
>>			#address-cells =3D <1>;
>>			#size-cells =3D <0>;
>>			device_type =3D "mdio";
>>			compatible =3D "gianfar";=09
>>			reg =3D <24520 20>;
>>			phy1: ethernet-phy@1 {
>>				interrupt-parent =3D <&mpic>;
>>				interrupts =3D <37 1>;
>>				reg =3D <11>;
>>				device_type =3D "ethernet-phy";
>>			};
>>		};=09
>>		ethernet@25000 {
>>			#address-cells =3D <1>;
>>			#size-cells =3D <0>;
>>			device_type =3D "network";
>>			model =3D "eTSEC";
>>			compatible =3D "gianfar";
>>			reg =3D <25000 1000>;
>>			local-mac-address =3D [ 00 00 00 00 00 00 ];
>>			interrupts =3D <23 2 24 2 28 2>;
>>			interrupt-parent =3D <&mpic>;
>>			phy-handle =3D <&phy1>;
>>		};
>>		mpic: pic@40000 {
>>			clock-frequency =3D <0>;
>>			interrupt-controller;
>>			#address-cells =3D <0>;
>>			#interrupt-cells =3D <2>;
>>			reg =3D <40000 40000>;
>>			built-in;
>>			compatible =3D "chrp,open-pic";
>>			device_type =3D "open-pic";
>>                        big-endian;
>>		};

The device tree seems to be parsed OK:

>> of_irq_map_one: dev=3D/soc8548@e0000000/mdio@24520/ethernet-phy@1,
index=3D0
>>  	intsize=3D2 intlen=3D2
>> of_irq_map_raw: =
par=3D/soc8548@e0000000/pic@40000,intspec=3D[0x00000037
>>  	0x00000001...],ointsize=3D2
>> of_irq_map_raw: ipar=3D/soc8548@e0000000/pic@40000, size=3D2
>> mpic: xlate (2 cells: 0x00000037 0x00000001) to line 0x37 sense 0x8

Now, that looks OK! Those are what I would expect. And when the=20
mdio/phy are probed, configured, and the 88E1145 interrupt (EXT7=20
(0x37H)) is enabled, the interrupt never (seemingly) gets cleared,
and basically hangs the entire box up and eventually it panics!

I don't even have an external phy(SFP) connected to this 88e1148 phy..

I am at a lost - is there something I am missing in device tree?=20
Help mr. wizard (Kumar?)...

Tom

Re: Trying to use Device Tree...and getting continuous interrupts from attached 88e1145

[Benjamin Herrenschmidt]

On Fri, 2007-08-03 at 18:54 -0400, Morrison, Tom wrote:
> Now, that looks OK! Those are what I would expect. And when the 
> mdio/phy are probed, configured, and the 88E1145 interrupt (EXT7 
> (0x37H)) is enabled, the interrupt never (seemingly) gets cleared,
> and basically hangs the entire box up and eventually it panics!
> 
> I don't even have an external phy(SFP) connected to this 88e1148 phy..
> 
> I am at a lost - is there something I am missing in device tree? 
> Help mr. wizard (Kumar?)... 

Double check you got the interrupt sense and polarity right.

Ben.

Re: Trying to use Device Tree...and getting continuous interrupts from attached 88e1145

[Andy Fleming]

On Aug 3, 2007, at 17:54, Morrison, Tom wrote:

> All,
>
> Connected to eth1 (etsec2) of my mpc8548 cpu is a 88E1145 and I
> am trying to get the core functionality running with the device tree
> paradigm - I know the sense of the 88E1145 is active-low for my
> mpc8548 board and have it working with an older 2.6.11++ kernel.
>
> I built this new kernel with the marvell driver - it seemingly
> does all the same things we did in the 2.6.11 kernel in separate
> spots...
>
> Here is the appropriate parts of my device tree for this part of the
> core...
>
>>> 		mdio@24520 {
>>> 			#address-cells = <1>;
>>> 			#size-cells = <0>;
>>> 			device_type = "mdio";
>>> 			compatible = "gianfar";	
>>> 			reg = <24520 20>;
>>> 			phy1: ethernet-phy@1 {
>>> 				interrupt-parent = <&mpic>;
>>> 				interrupts = <37 1>;


How recent of a kernel are you using?  The current kernel assigns the  
external interrupts to be the low 12 interrupts, which would make  
your interrupt assignment wrong.

>
> Now, that looks OK! Those are what I would expect. And when the
> mdio/phy are probed, configured, and the 88E1145 interrupt (EXT7
> (0x37H)) is enabled, the interrupt never (seemingly) gets cleared,
> and basically hangs the entire box up and eventually it panics!


Can you determine where it's hanging.  Or whether it is calling  
phy_interrupt() at all?  phy_interrupt should be disabling the  
interrupt at the PIC, and then the interrupt should be handled in a  
work queue.

Andy

RE: Trying to use Device Tree...and getting continuous interrupts from attached 88e1145

[Morrison, Tom]

It turns out that Andy was right and I had not understand the=20
NEW MPIC format for the definition of the external interrupts.
This was different than the 2.6.11++ kernel...

Thank you Ben & Andy for your suggestions, unfortunately,
I had to learn the hard way that it was more fundamental
than I had imagined...

I continue to have problems, but I will itemize those in a
separate email.

Tom Morrison


-----Original Message-----
From: Andy Fleming [mailto:afleming@freescale.com]=20
Sent: Monday, August 06, 2007 2:10 PM
To: Morrison, Tom
Cc: linuxppc-dev@ozlabs.org
Subject: Re: Trying to use Device Tree...and getting continuous
interrupts from attached 88e1145

<Snip>
>>> 		mdio@24520 {
>>> 			#address-cells =3D <1>;
>>> 			#size-cells =3D <0>;
>>> 			device_type =3D "mdio";
>>> 			compatible =3D "gianfar";=09
>>> 			reg =3D <24520 20>;
>>> 			phy1: ethernet-phy@1 {
>>> 				interrupt-parent =3D <&mpic>;
>>> 				interrupts =3D <37 1>;


> How recent of a kernel are you using?  The current kernel assigns=20
> the  external interrupts to be the low 12 interrupts, which would make

> your interrupt assignment wrong.