From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Olaf Hering <olh@suse.de>
Cc: Robert Hancock <hancockr@shaw.ca>,
linuxppc-dev@ozlabs.org,
Stefan Richter <stefanr@s5r6.in-berlin.de>,
stable@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.22.y] ieee1394: revert "sbp2: enforce 32bit DMA mapping"
Date: Tue, 07 Aug 2007 07:47:28 +1000 [thread overview]
Message-ID: <1186436848.938.75.camel@localhost.localdomain> (raw)
In-Reply-To: <20070806135124.GA2900@suse.de>
On Mon, 2007-08-06 at 15:51 +0200, Olaf Hering wrote:
> On Mon, Aug 06, Benjamin Herrenschmidt wrote:
>
> > BTW. Any reason why you don't set the DMA mask in the ohci driver rather
> > than the sbp2 one ?
>
> I used this patch, and the attached CD was found.
> What dma mask should be used in ohci_probe()?
Allright. So I see two problems here:
- in the code that powerpc uses to generate the PCI tree based on the
open firmware device-tree (instead of probing the bus), we don't set the
dma mask to the default ffffffff.
- our implementation of dma_supported() incorrectly tests against the
-previous- dma mask instead of the one we pass in as an argument.
I'll send a patch later today for you guys to test.
In addition, make sure that ieee1394 properly uses the parent PCI dev
and not some other intermediary struct device for the dma mask. Oh and,
don't do the set_dma_mask() in sbp2, it has nothing to do there. It
should be in the ohci1394 driver.
Cheers,
Ben.
next prev parent reply other threads:[~2007-08-06 21:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fa.Qn3Snqoik3hhnxcA6HqjGV0Yzck@ifi.uio.no>
[not found] ` <46B4B3DC.7020609@shaw.ca>
2007-08-04 17:30 ` [PATCH 2.6.22.y] ieee1394: revert "sbp2: enforce 32bit DMA mapping" Stefan Richter
2007-08-05 0:15 ` Benjamin Herrenschmidt
2007-08-05 7:54 ` Stefan Richter
2007-08-05 22:04 ` Benjamin Herrenschmidt
2007-08-06 13:51 ` Olaf Hering
2007-08-06 21:47 ` Benjamin Herrenschmidt [this message]
2007-08-06 22:22 ` Stefan Richter
2007-08-06 22:25 ` Robert Hancock
2007-08-06 22:32 ` Benjamin Herrenschmidt
2007-08-06 22:35 ` Robert Hancock
2007-08-06 22:59 ` Stefan Richter
2007-08-06 22:48 ` Stefan Richter
2007-08-07 2:18 ` Andi Kleen
2007-08-06 22:29 ` Benjamin Herrenschmidt
2007-08-06 11:58 ` Olaf Hering
2007-08-06 21:43 ` Benjamin Herrenschmidt
2007-08-06 22:05 ` [PATCH] powerpc: Fix initialization and usage of dma_mask Benjamin Herrenschmidt
2007-08-06 22:30 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1186436848.938.75.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=hancockr@shaw.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=olh@suse.de \
--cc=stable@kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).