From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Tony Breeds <tony@bakeyournoodle.com>
Cc: LinuxPPC-dev <linuxppc-dev@ozlabs.org>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: Device tree aware EMAC driver
Date: Wed, 08 Aug 2007 17:33:23 +1000 [thread overview]
Message-ID: <1186558403.938.166.camel@localhost.localdomain> (raw)
In-Reply-To: <20070808031643.GK10345@bakeyournoodle.com>
> * c++ style comments
Ouch... I haven't removed them all ? I promise I didn't -add- any :-)
> * in emac_probe():
> + /* Wait for dependent devices */
> + err = -ENODEV;
> + err = emac_wait_deps(dev);
> The initialisation to -ENODEV is pointless right?
Leftover from when it was coded differently yes.
> * s/get_property/of_get_property/g or you'll make sfr grumpy ;)
> * In drivers/net/ibm_newemac/Makefile, I think the preferred method is
> to use ibm_newemac-y rather than ibm_newemac-objs.
>
> Is there any reason to leave config IBM_NEW_EMAC (and IBM_EMAC) in
> drivers/net/Kconfig ? It seems to me they'd be nicer to in the
> appropriate drivers/net/*Kconfig.
Probably.
Ben.
next prev parent reply other threads:[~2007-08-08 7:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-07 6:22 Device tree aware EMAC driver David Gibson
2007-08-07 12:15 ` Josh Boyer
2007-08-08 1:18 ` David Gibson
2007-08-08 3:16 ` Tony Breeds
2007-08-08 5:09 ` David Gibson
2007-08-08 7:34 ` Benjamin Herrenschmidt
2007-08-08 7:33 ` Benjamin Herrenschmidt [this message]
2007-08-10 20:39 ` Segher Boessenkool
2007-08-13 1:05 ` David Gibson
2007-08-11 3:51 ` Olof Johansson
[not found] <20070823035601.GL7042@localhost.localdomain>
2007-08-23 7:30 ` Benjamin Herrenschmidt
2007-09-14 22:37 ` Josh Boyer
-- strict thread matches above, loose matches on Subject: below --
2007-05-30 6:17 David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1186558403.938.166.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=tony@bakeyournoodle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).