From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, Nathan Lynch <ntl@pobox.com>,
Paul Mackerras <paulus@samba.org>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [RFC/PATCH] remove gratuitous reads from maple pci config space methods
Date: Sat, 11 Aug 2007 18:41:29 -0500 [thread overview]
Message-ID: <1186875689.1576.44.camel@localhost.localdomain> (raw)
In-Reply-To: <6681fdad128303fc62c86c2345aa33a4@kernel.crashing.org>
> It should be fine on PowerMac as well -- all G5s use U3/U4,
> the workaround is for certain older Apple bridge chips.
Yeah, remove them. The workaround that is needed afaik is really only
the one that reads back the -address- before accessing the data register
(and I think it's sill needed on U3), but it's unrelated to what that
patch changes.
As I said on IRC, I suspect those reads come from misguided attempts on
my part to avoid the processor itself posting those writes, since we
want config space access to be synchronous all the way. In that case,
however, a sync will do the job just fine to ensure the previous write
did hit the bridge.
Cheers,
Ben.
prev parent reply other threads:[~2007-08-11 23:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-09 0:50 [RFC/PATCH] remove gratuitous reads from maple pci config space methods Nathan Lynch
2007-08-09 0:55 ` Benjamin Herrenschmidt
2007-08-09 1:04 ` Nathan Lynch
2007-08-09 1:14 ` Benjamin Herrenschmidt
2007-08-09 20:03 ` Olof Johansson
2007-08-09 3:05 ` David Gibson
2007-08-09 4:16 ` Nathan Lynch
2007-08-09 4:18 ` David Gibson
2007-08-09 10:40 ` Segher Boessenkool
2007-08-09 21:24 ` Nathan Lynch
2007-08-10 17:58 ` Segher Boessenkool
2007-08-11 23:41 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1186875689.1576.44.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=ntl@pobox.com \
--cc=paulus@samba.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).