linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Joachim Foerster <mls.JOFT@gmx.de>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel <alsa-devel@alsa-project.org>,
	Lorenz Kolb <lorenz.kolb@lkmail.de>,
	Stephen Neuendorffer <stephen.neuendorffer@xilinx.com>,
	linuxppc-embedded <linuxppc-embedded@ozlabs.org>
Subject: Re: [PATCH] [ML403-AC97CR] Fix (device/driver) name registered with platform bus
Date: Wed, 15 Aug 2007 20:45:22 +0200	[thread overview]
Message-ID: <1187203522.1376.18.camel@localhost> (raw)
In-Reply-To: <1186849433.20835.33.camel@localhost>

Hi all,

below, you'll find a very small patch: In the current state, platform
bus _never_ activates (= calls probe() callback on) the driver, because
the driver's name has a dash and the device's name has an underscore. I
made this horrible change _after_ I tested the final patch, which I
posted on Saturday. Sorry.

From: Joachim Foerster <JOFT@gmx.de>

Names inside struct platform_device and struct platform_driver seem to
need underscores instead of dashes.

(Patch for Linus' master branch, date 2007/08/08 _including_ my patches
sent on Saturday)

Signed-off-by: Joachim Foerster <JOFT@gmx.de>
---
 arch/ppc/syslib/virtex_devices.c |    2 +-
 sound/drivers/ml403-ac97cr.c     |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/ppc/syslib/virtex_devices.c b/arch/ppc/syslib/virtex_devices.c
index d0b04d6..9fa10b1 100644
--- a/arch/ppc/syslib/virtex_devices.c
+++ b/arch/ppc/syslib/virtex_devices.c
@@ -122,7 +122,7 @@
 }
 
 #define XPAR_AC97_CONTROLLER_REFERENCE(num) { \
-	.name = "ml403-ac97cr", \
+	.name = "ml403_ac97cr", \
 	.id = num, \
 	.num_resources = 3, \
 	.resource = (struct resource[]) { \
diff --git a/sound/drivers/ml403-ac97cr.c b/sound/drivers/ml403-ac97cr.c
index 2222315..2636249 100644
--- a/sound/drivers/ml403-ac97cr.c
+++ b/sound/drivers/ml403-ac97cr.c
@@ -66,7 +66,7 @@
 #include "pcm-indirect2.h"
 
 
-#define SND_ML403_AC97CR_DRIVER "ml403-ac97cr"
+#define SND_ML403_AC97CR_DRIVER "ml403_ac97cr"
 
 MODULE_AUTHOR("Joachim Foerster <JOFT@gmx.de>");
 MODULE_DESCRIPTION("Xilinx ML403 AC97 Controller Reference");
-- 
1.5.2.4

  reply	other threads:[~2007-08-15 18:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-09 10:36 [PATCH 1/2] Xlinx ML403 AC97 Controller Reference device driver Joachim Förster
2007-08-09 17:13 ` [alsa-devel] " Takashi Iwai
2007-08-09 19:44   ` Joachim Förster
2007-08-09 22:27     ` Takashi Iwai
2007-08-10 11:50   ` Joachim Förster
2007-08-10 12:07     ` Takashi Iwai
2007-08-11 16:23   ` [PATCHv2 1/2] Xilinx " Joachim Förster
2007-08-15 18:45     ` Joachim Foerster [this message]
2007-08-11 16:24   ` [PATCHv2 2/2] [VIRTEX] Register AC97 Controller Reference with the platform bus Joachim Förster
2007-08-09 17:49 ` [PATCH 1/2] Xlinx ML403 AC97 Controller Reference device driver Grant Likely
2007-08-09 20:01   ` Joachim Förster
2007-08-09 20:07     ` Grant Likely
2007-08-09 22:30     ` Takashi Iwai
2007-08-09 18:17 ` Stephen Neuendorffer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1187203522.1376.18.camel@localhost \
    --to=mls.joft@gmx.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linuxppc-embedded@ozlabs.org \
    --cc=lorenz.kolb@lkmail.de \
    --cc=stephen.neuendorffer@xilinx.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).