From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Timur Tabi <timur@freescale.com>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH v2] powerpc: add setmaskedbits macros
Date: Thu, 16 Aug 2007 11:40:18 -0500 [thread overview]
Message-ID: <1187282419.30809.35.camel@localhost.localdomain> (raw)
In-Reply-To: <46C46C9A.2000107@freescale.com>
On Thu, 2007-08-16 at 10:26 -0500, Timur Tabi wrote:
> Kumar Gala wrote:
>
> >> setmaskedbits_be32(&uccp->gumr_l,
> >> UCC_SLOW_GUMR_L_MODE_QMC | UCC_SLOW_GUMR_L_TDCR_1 |
> >> UCC_SLOW_GUMR_L_RDCR_16,
> >> UCC_SLOW_GUMR_L_MODE_MASK | UCC_SLOW_GUMR_L_TDCR_MASK |
> >> UCC_SLOW_GUMR_L_RDCR_MASK);
> >>
> >> setmaskedbits_be32(&uccp->gumr_h,
> >> UCC_SLOW_GUMR_H_SUART | UCC_SLOW_GUMR_H_TRX |
> >> UCC_SLOW_GUMR_H_TTX, UCC_SLOW_GUMR_H_RFW);
> >
> > Can you also show what the UCC_SLOW* values look like.
>
> The second example is actually a trick that lets me set some bits and clear
> others in one shot, so for the gumr_h register, all of the above values are
> single bits. I guess that's not a good example.
Such tricks deserve at least a comment.
Ben.
next prev parent reply other threads:[~2007-08-16 16:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-15 21:30 [PATCH v2] powerpc: add setmaskedbits macros Timur Tabi
2007-08-16 3:22 ` Kumar Gala
2007-08-16 15:18 ` Timur Tabi
2007-08-16 15:21 ` Kumar Gala
2007-08-16 15:26 ` Timur Tabi
2007-08-16 16:40 ` Benjamin Herrenschmidt [this message]
2007-08-16 17:45 ` Timur Tabi
2007-08-16 3:55 ` Michael Ellerman
2007-08-16 7:19 ` Geert Uytterhoeven
2007-08-16 15:27 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1187282419.30809.35.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).