From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 4BB56DDE01 for ; Fri, 24 Aug 2007 02:27:17 +1000 (EST) Subject: Re: wmb vs mmiowb From: Benjamin Herrenschmidt To: Linus Torvalds In-Reply-To: References: <20070822045714.GD26374@wotan.suse.de> <200708221202.12403.jesse.barnes@intel.com> <20070823022043.GB18788@wotan.suse.de> <20070823042038.GI18788@wotan.suse.de> Content-Type: text/plain Date: Thu, 23 Aug 2007 18:27:42 +0200 Message-Id: <1187886462.5972.17.camel@localhost.localdomain> Mime-Version: 1.0 Cc: Nick Piggin , linux-ia64@vger.kernel.org, Jesse Barnes , linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 2007-08-23 at 09:16 -0700, Linus Torvalds wrote: > > On Thu, 23 Aug 2007, Nick Piggin wrote: > > > > Also, FWIW, there are some advantages of deferring the mmiowb thingy > > until the point of unlock. > > And that is exactly what ppc64 does. > > But you're missing a big point: for 99.9% of all hardware, mmiowb() is a > total no-op. So when you talk about "advantages", you're not talking about > any *real* advantage, are you? I wonder whether it might be worth removing mmiowb and having all archs that matter do like ppc64 though... It's just yet another confusing barrier that most driver writers get wrong.. Cheers, Ben.