From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tglx@linutronix.de>
Received: from mail.tglx.de (www.osadl.org [213.239.205.134])
	by ozlabs.org (Postfix) with ESMTP id 3370BDDE3C
	for <linuxppc-dev@ozlabs.org>; Tue, 11 Sep 2007 18:21:43 +1000 (EST)
Subject: Re: Fix "no_sync_cmos_clock"  logic inversion in kernel/time/ntp.c
From: Thomas Gleixner <tglx@linutronix.de>
To: Tony Breeds <tony@bakeyournoodle.com>
In-Reply-To: <20070911074608.GD9814@bakeyournoodle.com>
References: <20070911074608.GD9814@bakeyournoodle.com>
Content-Type: text/plain
Date: Tue, 11 Sep 2007 09:57:50 +0200
Message-Id: <1189497470.22589.3.camel@chaos>
Mime-Version: 1.0
Cc: zach@vmware.com, John Stultz <johnstul@us.ibm.com>,
	Linux Kernel ML <linux-kernel@vger.kernel.org>,
	LinuxPPC-dev <linuxppc-dev@ozlabs.org>, Paul Mackerras <paulus@samba.org>,
	Andrew Morton <akpm@linux-foundation.org>
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.ozlabs.org>
List-Unsubscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=unsubscribe>
List-Archive: <http://ozlabs.org/pipermail/linuxppc-dev>
List-Post: <mailto:linuxppc-dev@ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@ozlabs.org?subject=help>
List-Subscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=subscribe>

On Tue, 2007-09-11 at 17:46 +1000, Tony Breeds wrote:
> Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
> 
> ---
> 
> Seems to me that this timer will only get started on platforms that say
> they don't want it?

Hell, yes. Good catch !

	tglx

>  kernel/time/ntp.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: working/kernel/time/ntp.c
> ===================================================================
> --- working.orig/kernel/time/ntp.c	2007-09-11 17:34:44.000000000 +1000
> +++ working/kernel/time/ntp.c	2007-09-11 17:34:55.000000000 +1000
> @@ -226,7 +226,7 @@ static void sync_cmos_clock(unsigned lon
>  
>  static void notify_cmos_timer(void)
>  {
> -	if (no_sync_cmos_clock)
> +	if (!no_sync_cmos_clock)
>  		mod_timer(&sync_cmos_timer, jiffies + 1);
>  }
>  
> 
> Yours Tony
> 
>   linux.conf.au        http://linux.conf.au/ || http://lca2008.linux.org.au/
>   Jan 28 - Feb 02 2008 The Australian Linux Technical Conference!
>