* Fix "no_sync_cmos_clock" logic inversion in kernel/time/ntp.c
@ 2007-09-11 7:46 Tony Breeds
2007-09-11 7:57 ` Thomas Gleixner
0 siblings, 1 reply; 2+ messages in thread
From: Tony Breeds @ 2007-09-11 7:46 UTC (permalink / raw)
To: Linux Kernel ML, LinuxPPC-dev
Cc: zach, John Stultz, Paul Mackerras, Andrew Morton, Thomas Gleixner
Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
---
Seems to me that this timer will only get started on platforms that say
they don't want it?
kernel/time/ntp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: working/kernel/time/ntp.c
===================================================================
--- working.orig/kernel/time/ntp.c 2007-09-11 17:34:44.000000000 +1000
+++ working/kernel/time/ntp.c 2007-09-11 17:34:55.000000000 +1000
@@ -226,7 +226,7 @@ static void sync_cmos_clock(unsigned lon
static void notify_cmos_timer(void)
{
- if (no_sync_cmos_clock)
+ if (!no_sync_cmos_clock)
mod_timer(&sync_cmos_timer, jiffies + 1);
}
Yours Tony
linux.conf.au http://linux.conf.au/ || http://lca2008.linux.org.au/
Jan 28 - Feb 02 2008 The Australian Linux Technical Conference!
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: Fix "no_sync_cmos_clock" logic inversion in kernel/time/ntp.c
2007-09-11 7:46 Fix "no_sync_cmos_clock" logic inversion in kernel/time/ntp.c Tony Breeds
@ 2007-09-11 7:57 ` Thomas Gleixner
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Gleixner @ 2007-09-11 7:57 UTC (permalink / raw)
To: Tony Breeds
Cc: zach, John Stultz, Linux Kernel ML, LinuxPPC-dev, Paul Mackerras,
Andrew Morton
On Tue, 2007-09-11 at 17:46 +1000, Tony Breeds wrote:
> Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
>
> ---
>
> Seems to me that this timer will only get started on platforms that say
> they don't want it?
Hell, yes. Good catch !
tglx
> kernel/time/ntp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: working/kernel/time/ntp.c
> ===================================================================
> --- working.orig/kernel/time/ntp.c 2007-09-11 17:34:44.000000000 +1000
> +++ working/kernel/time/ntp.c 2007-09-11 17:34:55.000000000 +1000
> @@ -226,7 +226,7 @@ static void sync_cmos_clock(unsigned lon
>
> static void notify_cmos_timer(void)
> {
> - if (no_sync_cmos_clock)
> + if (!no_sync_cmos_clock)
> mod_timer(&sync_cmos_timer, jiffies + 1);
> }
>
>
> Yours Tony
>
> linux.conf.au http://linux.conf.au/ || http://lca2008.linux.org.au/
> Jan 28 - Feb 02 2008 The Australian Linux Technical Conference!
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-09-11 8:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-11 7:46 Fix "no_sync_cmos_clock" logic inversion in kernel/time/ntp.c Tony Breeds
2007-09-11 7:57 ` Thomas Gleixner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).