Re: [PATCH 2/2] fsl/embedded6xx: don't cast the result of of_get_property

Stephen Rothwell
2007-09-26T00:44:19Z

[-- Attachment #1: Type: text/plain, Size: 592 bytes --]

On Fri, 14 Sep 2007 15:46:40 +1000 Jeremy Kerr <jk@ozlabs.org> wrote:
>
> - avr_clock = *(u32*)of_get_property(avr, "clock-frequency", &len);
> - phys_addr = ((u32*)of_get_property(avr, "reg", &len))[0];
> + phys_addr = of_get_property(avr, "reg", &len);
> + avr_clock_prop = of_get_property(avr, "clock-frequency", &len);

If you don't use the value of the len variable, then you can pass NULL to
of_get_property.

> + if (!avr_clock || !phys_addr[0])

Not *phys_addr?

--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]