* [PATCH] fix xmon input on 440
@ 2007-09-14 20:44 Hollis Blanchard
2007-09-17 2:52 ` David Gibson
2007-09-17 12:24 ` Milton Miller
0 siblings, 2 replies; 7+ messages in thread
From: Hollis Blanchard @ 2007-09-14 20:44 UTC (permalink / raw)
To: Josh Boyer; +Cc: linuxppc-dev
Implement udbg_getc() for 440, which fixes xmon input.
Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>
diff --git a/arch/powerpc/kernel/udbg_16550.c b/arch/powerpc/kernel/udbg_16550.c
--- a/arch/powerpc/kernel/udbg_16550.c
+++ b/arch/powerpc/kernel/udbg_16550.c
@@ -206,11 +206,22 @@ static void udbg_44x_as1_putc(char c)
}
}
+static int udbg_44x_as1_getc(void)
+{
+ if (udbg_comport) {
+ while ((as1_readb(&udbg_comport->lsr) & LSR_DR) == 0)
+ /* wait for char */;
+ return as1_readb(&udbg_comport->rbr);
+ }
+ return -1;
+}
+
void __init udbg_init_44x_as1(void)
{
udbg_comport =
(volatile struct NS16550 __iomem *)PPC44x_EARLY_DEBUG_VIRTADDR;
udbg_putc = udbg_44x_as1_putc;
+ udbg_getc = udbg_44x_as1_getc;
}
#endif /* CONFIG_PPC_EARLY_DEBUG_44x */
--
Hollis Blanchard
IBM Linux Technology Center
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] fix xmon input on 440 2007-09-14 20:44 [PATCH] fix xmon input on 440 Hollis Blanchard @ 2007-09-17 2:52 ` David Gibson 2007-09-17 3:26 ` Josh Boyer 2007-09-17 12:24 ` Milton Miller 1 sibling, 1 reply; 7+ messages in thread From: David Gibson @ 2007-09-17 2:52 UTC (permalink / raw) To: Hollis Blanchard; +Cc: linuxppc-dev On Fri, Sep 14, 2007 at 03:44:47PM -0500, Hollis Blanchard wrote: > Implement udbg_getc() for 440, which fixes xmon input. > Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com> Acked-by: David Gibson <david@gibson.dropbear.id.au> -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] fix xmon input on 440 2007-09-17 2:52 ` David Gibson @ 2007-09-17 3:26 ` Josh Boyer 2007-09-17 3:39 ` Olof Johansson 0 siblings, 1 reply; 7+ messages in thread From: Josh Boyer @ 2007-09-17 3:26 UTC (permalink / raw) To: David Gibson; +Cc: linuxppc-dev, Hollis Blanchard On Mon, 2007-09-17 at 12:52 +1000, David Gibson wrote: > On Fri, Sep 14, 2007 at 03:44:47PM -0500, Hollis Blanchard wrote: > > Implement udbg_getc() for 440, which fixes xmon input. > > Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com> > Acked-by: David Gibson <david@gibson.dropbear.id.au> > I fixed up the whitespace issues and applied it to my tree. Oh, and comments don't need semi-colons ;) josh ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] fix xmon input on 440 2007-09-17 3:26 ` Josh Boyer @ 2007-09-17 3:39 ` Olof Johansson 2007-09-17 4:15 ` Hollis Blanchard 0 siblings, 1 reply; 7+ messages in thread From: Olof Johansson @ 2007-09-17 3:39 UTC (permalink / raw) To: Josh Boyer; +Cc: linuxppc-dev, Hollis Blanchard, David Gibson On Sun, Sep 16, 2007 at 10:26:37PM -0500, Josh Boyer wrote: > On Mon, 2007-09-17 at 12:52 +1000, David Gibson wrote: > > On Fri, Sep 14, 2007 at 03:44:47PM -0500, Hollis Blanchard wrote: > > > Implement udbg_getc() for 440, which fixes xmon input. > > > Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com> > > Acked-by: David Gibson <david@gibson.dropbear.id.au> > > > > I fixed up the whitespace issues and applied it to my tree. Oh, and > comments don't need semi-colons ;) Well, there's a big difference between: while (foo) /* moof */; return bar; and: while (foo) /* moof */ return bar; :-) ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] fix xmon input on 440 2007-09-17 3:39 ` Olof Johansson @ 2007-09-17 4:15 ` Hollis Blanchard 2007-09-17 10:58 ` Josh Boyer 0 siblings, 1 reply; 7+ messages in thread From: Hollis Blanchard @ 2007-09-17 4:15 UTC (permalink / raw) To: Olof Johansson; +Cc: linuxppc-dev, David Gibson On Sun, 2007-09-16 at 22:39 -0500, Olof Johansson wrote: > On Sun, Sep 16, 2007 at 10:26:37PM -0500, Josh Boyer wrote: > > On Mon, 2007-09-17 at 12:52 +1000, David Gibson wrote: > > > On Fri, Sep 14, 2007 at 03:44:47PM -0500, Hollis Blanchard wrote: > > > > Implement udbg_getc() for 440, which fixes xmon input. > > > > Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com> > > > Acked-by: David Gibson <david@gibson.dropbear.id.au> > > > > > > > I fixed up the whitespace issues and applied it to my tree. Oh, and > > comments don't need semi-colons ;) > > Well, there's a big difference between: > > while (foo) > /* moof */; > return bar; > > and: > while (foo) > /* moof */ > return bar; Right, so this commit is broken: http://git.infradead.org/?p=users/jwboyer/powerpc.git;a=commitdiff;h=81ec428065c01e37fb143ad31dc04fea27fddcac -- Hollis Blanchard IBM Linux Technology Center ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] fix xmon input on 440 2007-09-17 4:15 ` Hollis Blanchard @ 2007-09-17 10:58 ` Josh Boyer 0 siblings, 0 replies; 7+ messages in thread From: Josh Boyer @ 2007-09-17 10:58 UTC (permalink / raw) To: Hollis Blanchard; +Cc: Olof Johansson, linuxppc-dev, David Gibson On Sun, 2007-09-16 at 23:15 -0500, Hollis Blanchard wrote: > On Sun, 2007-09-16 at 22:39 -0500, Olof Johansson wrote: > > On Sun, Sep 16, 2007 at 10:26:37PM -0500, Josh Boyer wrote: > > > On Mon, 2007-09-17 at 12:52 +1000, David Gibson wrote: > > > > On Fri, Sep 14, 2007 at 03:44:47PM -0500, Hollis Blanchard wrote: > > > > > Implement udbg_getc() for 440, which fixes xmon input. > > > > > Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com> > > > > Acked-by: David Gibson <david@gibson.dropbear.id.au> > > > > > > > > > > I fixed up the whitespace issues and applied it to my tree. Oh, and > > > comments don't need semi-colons ;) > > > > Well, there's a big difference between: > > > > while (foo) > > /* moof */; > > return bar; > > > > and: > > while (foo) > > /* moof */ > > return bar; > > Right, so this commit is broken: > http://git.infradead.org/?p=users/jwboyer/powerpc.git;a=commitdiff;h=81ec428065c01e37fb143ad31dc04fea27fddcac Yes, it is. I realized that right as I was going to bed. I've pushed a new commit instead. http://git.infradead.org/?p=users/jwboyer/powerpc.git;a=commitdiff;h=88305119ccab262897ddbbceeb5a1f725f2b60fa josh ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] fix xmon input on 440 2007-09-14 20:44 [PATCH] fix xmon input on 440 Hollis Blanchard 2007-09-17 2:52 ` David Gibson @ 2007-09-17 12:24 ` Milton Miller 1 sibling, 0 replies; 7+ messages in thread From: Milton Miller @ 2007-09-17 12:24 UTC (permalink / raw) To: Hollis Blanchard; +Cc: ppcdev On Sat Sep 15 06:44:47 EST 2007, Hollis Blanchard wrote: > Implement udbg_getc() for 440, which fixes xmon input. > Signed-off-by: Hollis Blanchard <hollisb at us.ibm.com> > udbg_putc = udbg_44x_as1_putc; > + udbg_getc = udbg_44x_as1_getc; How about adding udbg_getc_poll as well? While there are no in-tree users, we can use it for console input later. milton ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2007-09-17 12:27 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2007-09-14 20:44 [PATCH] fix xmon input on 440 Hollis Blanchard 2007-09-17 2:52 ` David Gibson 2007-09-17 3:26 ` Josh Boyer 2007-09-17 3:39 ` Olof Johansson 2007-09-17 4:15 ` Hollis Blanchard 2007-09-17 10:58 ` Josh Boyer 2007-09-17 12:24 ` Milton Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).