From: Hollis Blanchard <hollisb@us.ibm.com>
To: Olof Johansson <olof@lixom.net>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>, David Gibson <dwg@au1.ibm.com>
Subject: Re: [PATCH] fix xmon input on 440
Date: Sun, 16 Sep 2007 23:15:21 -0500 [thread overview]
Message-ID: <1190002521.16747.1.camel@basalt> (raw)
In-Reply-To: <20070917033924.GA24914@lixom.net>
On Sun, 2007-09-16 at 22:39 -0500, Olof Johansson wrote:
> On Sun, Sep 16, 2007 at 10:26:37PM -0500, Josh Boyer wrote:
> > On Mon, 2007-09-17 at 12:52 +1000, David Gibson wrote:
> > > On Fri, Sep 14, 2007 at 03:44:47PM -0500, Hollis Blanchard wrote:
> > > > Implement udbg_getc() for 440, which fixes xmon input.
> > > > Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>
> > > Acked-by: David Gibson <david@gibson.dropbear.id.au>
> > >
> >
> > I fixed up the whitespace issues and applied it to my tree. Oh, and
> > comments don't need semi-colons ;)
>
> Well, there's a big difference between:
>
> while (foo)
> /* moof */;
> return bar;
>
> and:
> while (foo)
> /* moof */
> return bar;
Right, so this commit is broken:
http://git.infradead.org/?p=users/jwboyer/powerpc.git;a=commitdiff;h=81ec428065c01e37fb143ad31dc04fea27fddcac
--
Hollis Blanchard
IBM Linux Technology Center
next prev parent reply other threads:[~2007-09-17 4:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-14 20:44 [PATCH] fix xmon input on 440 Hollis Blanchard
2007-09-17 2:52 ` David Gibson
2007-09-17 3:26 ` Josh Boyer
2007-09-17 3:39 ` Olof Johansson
2007-09-17 4:15 ` Hollis Blanchard [this message]
2007-09-17 10:58 ` Josh Boyer
2007-09-17 12:24 ` Milton Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1190002521.16747.1.camel@basalt \
--to=hollisb@us.ibm.com \
--cc=dwg@au1.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).