linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Roland McGrath <roland@redhat.com>
Cc: David Woodhouse <dwmw2@redhat.com>,
	linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
	Paul Mackerras <paulus@samba.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 1/2] powerpc: ptrace CHECK_FULL_REGS
Date: Tue, 25 Sep 2007 10:33:26 +1000	[thread overview]
Message-ID: <1190680406.12382.9.camel@localhost.localdomain> (raw)
In-Reply-To: <20070924235052.5AFC24D04B7@magilla.localdomain>


On Mon, 2007-09-24 at 16:50 -0700, Roland McGrath wrote:
> This restores the CHECK_FULL_REGS sanity check to every place that can
> access the nonvolatile GPRs for ptrace.  This is already done for
> native-bitwidth PTRACE_PEEKUSR, but was omitted for many other cases
> (32-bit ptrace, PTRACE_GETREGS, etc.); I think there may have been more
> uniform checks before that were lost in the recent cleanup of GETREGS et al.

Yup, I think I ditched most of them.. for some reason I decided it
couldn't happen, but maybe I'm wrong ?

Cheers,
Ben.

> Signed-off-by: Roland McGrath <roland@redhat.com>
> ---
>  arch/powerpc/kernel/ptrace.c   |    4 ++++
>  arch/powerpc/kernel/ptrace32.c |    8 ++++++++
>  2 files changed, 12 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/powerpc/kernel/ptrace.c b/arch/powerpc/kernel/ptrace.c
> index 8a177bd..40d34b3 100644
> --- a/arch/powerpc/kernel/ptrace.c
> +++ b/arch/powerpc/kernel/ptrace.c
> @@ -331,6 +331,7 @@ static long arch_ptrace_old(struct task_struct *child, long request, long addr,
>  		unsigned long *reg = &((unsigned long *)child->thread.regs)[0];
>  		unsigned long __user *tmp = (unsigned long __user *)addr;
>  
> +		CHECK_FULL_REGS(child->thread.regs);
>  		for (i = 0; i < 32; i++) {
>  			ret = put_user(*reg, tmp);
>  			if (ret)
> @@ -346,6 +347,7 @@ static long arch_ptrace_old(struct task_struct *child, long request, long addr,
>  		unsigned long *reg = &((unsigned long *)child->thread.regs)[0];
>  		unsigned long __user *tmp = (unsigned long __user *)addr;
>  
> +		CHECK_FULL_REGS(child->thread.regs);
>  		for (i = 0; i < 32; i++) {
>  			ret = get_user(*reg, tmp);
>  			if (ret)
> @@ -517,6 +519,7 @@ long arch_ptrace(struct task_struct *child, long request, long addr, long data)
>  			ret = -EIO;
>  			break;
>  		}
> +		CHECK_FULL_REGS(child->thread.regs);
>  		ret = 0;
>  		for (ui = 0; ui < PT_REGS_COUNT; ui ++) {
>  			ret |= __put_user(ptrace_get_reg(child, ui),
> @@ -537,6 +540,7 @@ long arch_ptrace(struct task_struct *child, long request, long addr, long data)
>  			ret = -EIO;
>  			break;
>  		}
> +		CHECK_FULL_REGS(child->thread.regs);
>  		ret = 0;
>  		for (ui = 0; ui < PT_REGS_COUNT; ui ++) {
>  			ret = __get_user(tmp, (unsigned long __user *) data);
> diff --git a/arch/powerpc/kernel/ptrace32.c b/arch/powerpc/kernel/ptrace32.c
> index 9e6baea..6b86960 100644
> --- a/arch/powerpc/kernel/ptrace32.c
> +++ b/arch/powerpc/kernel/ptrace32.c
> @@ -53,6 +53,7 @@ static long compat_ptrace_old(struct task_struct *child, long request,
>  		unsigned long *reg = &((unsigned long *)child->thread.regs)[0];
>  		unsigned int __user *tmp = (unsigned int __user *)addr;
>  
> +		CHECK_FULL_REGS(child->thread.regs);
>  		for (i = 0; i < 32; i++) {
>  			ret = put_user(*reg, tmp);
>  			if (ret)
> @@ -68,6 +69,7 @@ static long compat_ptrace_old(struct task_struct *child, long request,
>  		unsigned long *reg = &((unsigned long *)child->thread.regs)[0];
>  		unsigned int __user *tmp = (unsigned int __user *)addr;
>  
> +		CHECK_FULL_REGS(child->thread.regs);
>  		for (i = 0; i < 32; i++) {
>  			ret = get_user(*reg, tmp);
>  			if (ret)
> @@ -164,6 +166,7 @@ long compat_sys_ptrace(int request, int pid, unsigned long addr,
>  		if ((addr & 3) || (index > PT_FPSCR32))
>  			break;
>  
> +		CHECK_FULL_REGS(child->thread.regs);
>  		if (index < PT_FPR0) {
>  			tmp = ptrace_get_reg(child, index);
>  		} else {
> @@ -210,6 +213,7 @@ long compat_sys_ptrace(int request, int pid, unsigned long addr,
>  		if ((addr & 3) || numReg > PT_FPSCR)
>  			break;
>  
> +		CHECK_FULL_REGS(child->thread.regs);
>  		if (numReg >= PT_FPR0) {
>  			flush_fp_to_thread(child);
>  			tmp = ((unsigned long int *)child->thread.fpr)[numReg - PT_FPR0];
> @@ -270,6 +274,7 @@ long compat_sys_ptrace(int request, int pid, unsigned long addr,
>  		if ((addr & 3) || (index > PT_FPSCR32))
>  			break;
>  
> +		CHECK_FULL_REGS(child->thread.regs);
>  		if (index < PT_FPR0) {
>  			ret = ptrace_put_reg(child, index, data);
>  		} else {
> @@ -307,6 +312,7 @@ long compat_sys_ptrace(int request, int pid, unsigned long addr,
>  		 */
>  		if ((addr & 3) || (numReg > PT_FPSCR))
>  			break;
> +		CHECK_FULL_REGS(child->thread.regs);
>  		if (numReg < PT_FPR0) {
>  			unsigned long freg = ptrace_get_reg(child, numReg);
>  			if (index % 2)
> @@ -342,6 +348,7 @@ long compat_sys_ptrace(int request, int pid, unsigned long addr,
>  			ret = -EIO;
>  			break;
>  		}
> +		CHECK_FULL_REGS(child->thread.regs);
>  		ret = 0;
>  		for (ui = 0; ui < PT_REGS_COUNT; ui ++) {
>  			ret |= __put_user(ptrace_get_reg(child, ui),
> @@ -359,6 +366,7 @@ long compat_sys_ptrace(int request, int pid, unsigned long addr,
>  			ret = -EIO;
>  			break;
>  		}
> +		CHECK_FULL_REGS(child->thread.regs);
>  		ret = 0;
>  		for (ui = 0; ui < PT_REGS_COUNT; ui ++) {
>  			ret = __get_user(tmp, (unsigned int __user *) data);
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev

  reply	other threads:[~2007-09-25  0:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-24 23:50 [PATCH 1/2] powerpc: ptrace CHECK_FULL_REGS Roland McGrath
2007-09-25  0:33 ` Benjamin Herrenschmidt [this message]
2007-09-25  0:59   ` Roland McGrath
2007-09-25  3:58     ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1190680406.12382.9.camel@localhost.localdomain \
    --to=benh@kernel.crashing.org \
    --cc=akpm@linux-foundation.org \
    --cc=dwmw2@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    --cc=roland@redhat.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).