linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Ishizaki Kou <kou.ishizaki@toshiba.co.jp>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org, arnd@arndb.de
Subject: Re: [PATCH 1/7] PowerPC64: Not to insert EA=0 entry at
Date: Fri, 28 Sep 2007 08:37:09 +1000	[thread overview]
Message-ID: <1190932629.6158.37.camel@pasglop> (raw)
In-Reply-To: <1190931617.6158.29.camel@pasglop>


> It should have been set in setup_64.c, in setup_paca() (which is called
> twice) in that statement:
> 
> 	local_paca = &paca[cpu];
> 
> As local_paca is defined as being a variable held in register r13. Maybe
> something bad's happening with the compiler ?

Can you check early_setup disassembly, see if r13 is assigned (it should
be in two spots) and if it's clobbered by the compiler somewhere ?

Also, you may want to try adding --ffixed-r13 to the CFLAGS in the
makefile and let us know if it makes a difference... r13 is marked
reserved by the ABI but segher seems to imply that gcc may decide to ues
it anyway (ouch !)

Ben.
 

  reply	other threads:[~2007-09-27 22:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-27  8:01 [PATCH 1/7] PowerPC64: Not to insert EA=0 entry at kou.ishizaki
2007-09-27  8:18 ` Benjamin Herrenschmidt
2007-09-27 11:22   ` Ishizaki Kou
2007-09-27 22:08     ` Benjamin Herrenschmidt
2007-09-27 22:20     ` Benjamin Herrenschmidt
2007-09-27 22:37       ` Benjamin Herrenschmidt [this message]
2007-09-28  8:04         ` Ishizaki Kou
2007-09-28  9:29           ` Benjamin Herrenschmidt
2007-09-28 16:33         ` Segher Boessenkool

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1190932629.6158.37.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=arnd@arndb.de \
    --cc=kou.ishizaki@toshiba.co.jp \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).