linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Gerhard Pircher <gerhard_pircher@gmx.net>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: Problem with OF interrupt parsing code
Date: Tue, 02 Oct 2007 07:39:47 +1000	[thread overview]
Message-ID: <1191274787.6310.17.camel@pasglop> (raw)
In-Reply-To: <20071001211120.156280@gmx.net>


On Mon, 2007-10-01 at 23:11 +0200, Gerhard Pircher wrote:
>         pci@80000000 {
>                 device_type = "pci";
>                 compatible = "mai-logic,articia-s";
>                 bus-frequency = <01fca055>;             // 33.3MHz
>                 bus-range = <0 ff>;
>                 ranges = <01000000 0 00000000 fe000000 0
> 00c00000       // PCI I/O
>                           02000000 0 80000000 80000000 0
> 7d000000       // PCI memory
>                           02000000 0 fd000000 fd000000 0
> 01000000>;     // PCI alias memory
>                 8259-interrupt-acknowledge = <fef00000>;
>                 interrupt-parent = <&i8259>;
>                 #interrupt-cells = <1>;
>                 #address-cells = <3>;
>                 #size-cells = <2>;
> 

Part of your problem is that interrupt-parent property. You shouldn't
have such a property in a PCI host bridge. It's not technically illegal,
but it's triggering the "loop" you've been experiencing.

If you want the parsing to fail for PCI devices (to get the fallback to
config space values), you need to make sure it does fail. 

Another option is to put an empty interrupt-map in there. That will
guarantee failure.

But that's all very ugly. I don't understand why you don't setup a
proper map either from your bootloader, zImage wrapper or even prom_init
or platform code.

Ben.

  reply	other threads:[~2007-10-01 21:39 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-01 21:00 Problem with OF interrupt parsing code Gerhard Pircher
2007-10-01 21:11 ` Gerhard Pircher
2007-10-01 21:39   ` Benjamin Herrenschmidt [this message]
2007-10-01 22:33   ` Segher Boessenkool
2007-10-01 22:54     ` Benjamin Herrenschmidt
2007-10-01 22:55       ` Benjamin Herrenschmidt
2007-10-01 23:36       ` Segher Boessenkool
2007-10-02 12:38       ` Gerhard Pircher
2007-10-02 22:03         ` Benjamin Herrenschmidt
2007-10-03  7:43           ` Gerhard Pircher
2007-10-01 21:26 ` Scott Wood
2007-10-01 21:37   ` Scott Wood
2007-10-01 21:43     ` Benjamin Herrenschmidt
2007-10-01 21:48       ` Scott Wood
2007-10-01 22:07         ` Benjamin Herrenschmidt
2007-10-02 12:46   ` Gerhard Pircher
2007-10-01 21:36 ` Benjamin Herrenschmidt
  -- strict thread matches above, loose matches on Subject: below --
2007-10-02 12:40 Gerhard Pircher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1191274787.6310.17.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=gerhard_pircher@gmx.net \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).