From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, David Gibson <dwg@au1.ibm.com>
Subject: Re: Problem with OF interrupt parsing code
Date: Tue, 02 Oct 2007 08:55:28 +1000 [thread overview]
Message-ID: <1191279328.6310.34.camel@pasglop> (raw)
In-Reply-To: <1191279244.6310.32.camel@pasglop>
On Tue, 2007-10-02 at 08:54 +1000, Benjamin Herrenschmidt wrote:
> It shoudn't normally happen. The reason it -does- happen in fact is
> that
> the above node is also missing the #interrupt-cells property, which
> cause the parent-lookup routine to skip it before it gets a chance to
> see that there's an "interrupt-controller" property in there.
>
> I'm not sure whether linux behaviour is a bug or not since I believe
> we
> are clearly in undefined-land as an interrupt controller should always
> have a #interrupt-cells property.
That's btw something we could add as a warning to dtc...
A node with "interrupt-controller" or "interrupt-map" in it should
always have a #interrupt-cells property.
Ben.
next prev parent reply other threads:[~2007-10-01 22:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-01 21:00 Problem with OF interrupt parsing code Gerhard Pircher
2007-10-01 21:11 ` Gerhard Pircher
2007-10-01 21:39 ` Benjamin Herrenschmidt
2007-10-01 22:33 ` Segher Boessenkool
2007-10-01 22:54 ` Benjamin Herrenschmidt
2007-10-01 22:55 ` Benjamin Herrenschmidt [this message]
2007-10-01 23:36 ` Segher Boessenkool
2007-10-02 12:38 ` Gerhard Pircher
2007-10-02 22:03 ` Benjamin Herrenschmidt
2007-10-03 7:43 ` Gerhard Pircher
2007-10-01 21:26 ` Scott Wood
2007-10-01 21:37 ` Scott Wood
2007-10-01 21:43 ` Benjamin Herrenschmidt
2007-10-01 21:48 ` Scott Wood
2007-10-01 22:07 ` Benjamin Herrenschmidt
2007-10-02 12:46 ` Gerhard Pircher
2007-10-01 21:36 ` Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2007-10-02 12:40 Gerhard Pircher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1191279328.6310.34.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=dwg@au1.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).