From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org, david@gibson.dropbear.id.au
Subject: Re: PowerPC: new EMAC driver typo fix
Date: Tue, 02 Oct 2007 10:10:33 +1000 [thread overview]
Message-ID: <1191283833.6310.42.camel@pasglop> (raw)
In-Reply-To: <1191283028.10089.15.camel@localhost.localdomain>
On Mon, 2007-10-01 at 18:57 -0500, Josh Boyer wrote:
> On Mon, 2007-10-01 at 18:23 +0400, Valentine Barshak wrote:
> > This looks like typo. Please, apply this patch to fix.
> >
> > diff -ruNp linux-2.6.orig/drivers/net/ibm_newemac/core.c linux-2.6/drivers/net/ibm_newemac/core.c
> > --- linux-2.6.orig/drivers/net/ibm_newemac/core.c 2007-10-01 17:23:35.000000000 +0400
> > +++ linux-2.6/drivers/net/ibm_newemac/core.c 2007-10-01 17:44:57.000000000 +0400
> > @@ -1232,9 +1232,9 @@ static inline int emac_xmit_finish(struc
> > * instead
> > */
> > if (emac_has_feature(dev, EMAC_FTR_EMAC4))
> > - out_be32(&p->tmr0, EMAC_TMR0_XMIT);
> > - else
> > out_be32(&p->tmr0, EMAC4_TMR0_XMIT);
> > + else
> > + out_be32(&p->tmr0, EMAC_TMR0_XMIT);
> >
> > if (unlikely(++dev->tx_cnt == NUM_TX_BUFF)) {
> > netif_stop_queue(ndev);
>
> No Signed-off-by: line.
>
> The patch looks sane otherwise. David, Ben, comments?
It does definitely look like a genuine typo so Acked by me.
Ben.
next prev parent reply other threads:[~2007-10-02 0:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-01 14:23 PowerPC: new EMAC driver typo fix Valentine Barshak
2007-10-01 23:57 ` Josh Boyer
2007-10-02 0:10 ` Benjamin Herrenschmidt [this message]
2007-10-02 12:01 ` [PATCH] Fix typo in new EMAC driver Valentine Barshak
2007-10-02 17:49 ` Josh Boyer
2007-10-02 17:59 ` Jeff Garzik
2007-10-03 17:51 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1191283833.6310.42.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=david@gibson.dropbear.id.au \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).