From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: michael@ellerman.id.au
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 6/7] Add dcr_map_reg() helper
Date: Tue, 02 Oct 2007 16:22:45 +1000 [thread overview]
Message-ID: <1191306165.6310.103.camel@pasglop> (raw)
In-Reply-To: <1191304300.6593.2.camel@concordia>
On Tue, 2007-10-02 at 15:51 +1000, Michael Ellerman wrote:
> On Tue, 2007-10-02 at 15:19 +1000, Benjamin Herrenschmidt wrote:
> > On Mon, 2007-09-17 at 16:05 +1000, Michael Ellerman wrote:
> > > Add a helper routine to map dcr's based on the "dcr-reg" property of
> > > a device node.
> > >
> > > Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
> >
> > Wouldn't it be more consistent to call it of_map_dcr ? Or maybe find an
> > even better name, but dcr_map_reg really sucks :-)
>
> That would give us dcr_map(), dcr_unmap() and of_map_dcr() - which
> doesn't strike me as more consistent.
>
> I don't particularly like dcr_map_reg(), but I think it's at least
> obvious that it's a variant of dcr_map() and that it has something to do
> with a "reg" .. maybe even a "dcr-reg" :)
dcr_map_node maybe ? dcr_map_device ? dcr_map_property ? hrm...
allright, keep it that way if you want but heh, at least see if you can
come up with something better before it gets merged :-)
Ben
next prev parent reply other threads:[~2007-10-02 6:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-17 6:05 [PATCH 1/7] Store the base address in dcr_host_t Michael Ellerman
2007-09-17 6:05 ` [PATCH 3/7] Use dcr_host_t.base in ibm_emac_mal Michael Ellerman
2007-10-02 5:13 ` Benjamin Herrenschmidt
2007-10-02 6:06 ` Michael Ellerman
2007-09-17 6:05 ` [PATCH 2/7] Update mpic to use dcr_host_t.base Michael Ellerman
2007-10-02 5:12 ` Benjamin Herrenschmidt
2007-09-17 6:05 ` [PATCH 4/7] Update axon_msi " Michael Ellerman
2007-10-02 5:14 ` Benjamin Herrenschmidt
2007-09-17 6:05 ` [PATCH 5/7] Add dcr_host_t.base in dcr_read()/dcr_write() Michael Ellerman
2007-10-02 5:17 ` Benjamin Herrenschmidt
2007-09-17 6:05 ` [PATCH 6/7] Add dcr_map_reg() helper Michael Ellerman
2007-10-02 5:19 ` Benjamin Herrenschmidt
2007-10-02 5:51 ` Michael Ellerman
2007-10-02 6:22 ` Benjamin Herrenschmidt [this message]
2007-09-17 6:05 ` [PATCH 7/7] Remove msic_dcr_read() and use dcr_map_reg() in axon_msi.c Michael Ellerman
2007-10-02 5:20 ` Benjamin Herrenschmidt
2007-10-02 5:10 ` [PATCH 1/7] Store the base address in dcr_host_t Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1191306165.6310.103.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).