* [PATCH] Remove unnecessary memset from physmap_of driver
@ 2007-10-02 15:53 Valentine Barshak
2007-10-02 23:43 ` Paul Mackerras
0 siblings, 1 reply; 4+ messages in thread
From: Valentine Barshak @ 2007-10-02 15:53 UTC (permalink / raw)
To: linuxppc-dev
No need for memset to zero memory here, since we use kzalloc.
Signed-off-by: Valentine Barshak <vbarshak@ru.mvista.com>
---
drivers/mtd/maps/physmap_of.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/maps/physmap_of.c b/drivers/mtd/maps/physmap_of.c
index cf75a56..aeed9ea 100644
--- a/drivers/mtd/maps/physmap_of.c
+++ b/drivers/mtd/maps/physmap_of.c
@@ -232,7 +232,6 @@ static int __devinit of_flash_probe(struct of_device *dev,
info = kzalloc(sizeof(*info), GFP_KERNEL);
if (!info)
goto err_out;
- memset(info, 0, sizeof(*info));
dev_set_drvdata(&dev->dev, info);
--
1.5.2.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Remove unnecessary memset from physmap_of driver
2007-10-02 15:53 [PATCH] Remove unnecessary memset from physmap_of driver Valentine Barshak
@ 2007-10-02 23:43 ` Paul Mackerras
2007-10-03 0:49 ` Josh Boyer
2007-10-03 14:05 ` [PATCH] mtd: remove " Valentine Barshak
0 siblings, 2 replies; 4+ messages in thread
From: Paul Mackerras @ 2007-10-02 23:43 UTC (permalink / raw)
To: Valentine Barshak; +Cc: linuxppc-dev
Valentine Barshak writes:
> No need for memset to zero memory here, since we use kzalloc.
>
> Signed-off-by: Valentine Barshak <vbarshak@ru.mvista.com>
> ---
> drivers/mtd/maps/physmap_of.c | 1 -
Please cc the mtd list (linux-mtd@lists.infradead.org) and/or David
Woodhouse on MTD patches. Posting them to linuxppc-dev isn't going to
get them upstream.
Paul.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Remove unnecessary memset from physmap_of driver
2007-10-02 23:43 ` Paul Mackerras
@ 2007-10-03 0:49 ` Josh Boyer
2007-10-03 14:05 ` [PATCH] mtd: remove " Valentine Barshak
1 sibling, 0 replies; 4+ messages in thread
From: Josh Boyer @ 2007-10-03 0:49 UTC (permalink / raw)
To: Paul Mackerras; +Cc: linuxppc-dev
On Wed, 2007-10-03 at 09:43 +1000, Paul Mackerras wrote:
> Valentine Barshak writes:
>
> > No need for memset to zero memory here, since we use kzalloc.
> >
> > Signed-off-by: Valentine Barshak <vbarshak@ru.mvista.com>
> > ---
> > drivers/mtd/maps/physmap_of.c | 1 -
>
> Please cc the mtd list (linux-mtd@lists.infradead.org) and/or David
> Woodhouse on MTD patches. Posting them to linuxppc-dev isn't going to
> get them upstream.
Except when I screw up and pull them into my tree. Which won't happen
again.
josh
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] mtd: remove unnecessary memset from physmap_of driver
2007-10-02 23:43 ` Paul Mackerras
2007-10-03 0:49 ` Josh Boyer
@ 2007-10-03 14:05 ` Valentine Barshak
1 sibling, 0 replies; 4+ messages in thread
From: Valentine Barshak @ 2007-10-03 14:05 UTC (permalink / raw)
To: linuxppc-dev; +Cc: linux-mtd
No need for memset to zero memory here, since we use kzalloc.
Signed-off-by: Valentine Barshak <vbarshak@ru.mvista.com>
---
drivers/mtd/maps/physmap_of.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/maps/physmap_of.c b/drivers/mtd/maps/physmap_of.c
index cf75a56..aeed9ea 100644
--- a/drivers/mtd/maps/physmap_of.c
+++ b/drivers/mtd/maps/physmap_of.c
@@ -232,7 +232,6 @@ static int __devinit of_flash_probe(struct of_device *dev,
info = kzalloc(sizeof(*info), GFP_KERNEL);
if (!info)
goto err_out;
- memset(info, 0, sizeof(*info));
dev_set_drvdata(&dev->dev, info);
--
1.5.2.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-10-03 14:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-02 15:53 [PATCH] Remove unnecessary memset from physmap_of driver Valentine Barshak
2007-10-02 23:43 ` Paul Mackerras
2007-10-03 0:49 ` Josh Boyer
2007-10-03 14:05 ` [PATCH] mtd: remove " Valentine Barshak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).