From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Arnd Bergmann <arnd.bergmann@de.ibm.com>,
linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
bluesmoke-devel@lists.sourceforge.net, cbe-oss-dev@ozlabs.org
Subject: Re: [PATCH 4/4] edac: Add Cell memory controller
Date: Thu, 04 Oct 2007 17:07:43 +1000 [thread overview]
Message-ID: <1191481663.22572.163.camel@pasglop> (raw)
In-Reply-To: <20071004170047.30883e02.sfr@canb.auug.org.au>
On Thu, 2007-10-04 at 17:00 +1000, Stephen Rothwell wrote:
> On Thu, 04 Oct 2007 15:40:44 +1000 Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> >
> > +++ linux-work/drivers/edac/cell-edac.c 2007-10-04 15:34:46.000000000 +1000
> > @@ -0,0 +1,258 @@
> > +#include <linux/module.h>
> > +#include <linux/init.h>
> > +#include <linux/platform_device.h>
> > +#include <linux/stop_machine.h>
> > +#include <asm/io.h>
> > +#include <asm/machdep.h>
> > +#include <asm/cell-regs.h>
>
> Since you use the of_ accessors, you should include linux/of.h
Looks like it gets pulled in by somebody on my behalf, I suppose I can
respin the patch though or just send a corrective add-on (I prefer the
later as I have to go home now :-)
Ben.
prev parent reply other threads:[~2007-10-04 7:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-04 5:40 [PATCH 0/4] Cell EDAC driver and dependencies Benjamin Herrenschmidt
2007-10-04 5:40 ` [PATCH 1/4] powerpc: Move cbe_regs.h to include/asm-powerpc/cell-regs.h Benjamin Herrenschmidt
2007-10-04 5:40 ` [PATCH 2/4] powerpc: Add Cell memory controller register defs and expose it Benjamin Herrenschmidt
2007-10-04 5:40 ` [PATCH 3/4] edac: Add Cell XDR memory definition Benjamin Herrenschmidt
2007-10-04 5:40 ` [PATCH 4/4] edac: Add Cell memory controller Benjamin Herrenschmidt
2007-10-04 7:00 ` Stephen Rothwell
2007-10-04 7:07 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1191481663.22572.163.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=arnd.bergmann@de.ibm.com \
--cc=bluesmoke-devel@lists.sourceforge.net \
--cc=cbe-oss-dev@ozlabs.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).