From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: shemminger@linux-foundation.org
Cc: netdev@vger.kernel.org, Roland Dreier <rdreier@cisco.com>,
"David S. Miller" <davem@davemloft.net>,
linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: [PATCH/RFC] net: Add __napi_sycnhronize() to sync with napi poll
Date: Tue, 16 Oct 2007 15:49:52 +1000 [thread overview]
Message-ID: <1192513792.19073.23.camel@pasglop> (raw)
net: Add __napi_sycnhronize() to sync with napi poll
The EMAC driver which needs to handle multiple devices with one
NAPI instance implements its own per-channel disable bit. However,
when setting such a bit, it needs to synchronize with the poller
(that is make sure that any pending poller instance has completed,
or is started late enough to see that disable bit).
This implements a low level __napi_synchronize() function to acheive
that. The underscores are to emphasis the low level aspect of it and
to discourage driver writers who don't know what they are doing to
use it (to please DaveM :-)
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
(Use correct address for Stephen this time)
If the approach is accepted, I would like to have this merged now
so the EMAC patch to make it work again can follow :-)
Note: I use msleep_interruptible(1); just like napi_disable(). However
I'm not too happy that the "hot" loop that results of a pending signal
here will spin without even a cpu_relax ... what do you guys think would
be the best way to handle this ?
Index: linux-work/include/linux/netdevice.h
===================================================================
--- linux-work.orig/include/linux/netdevice.h 2007-10-16 15:27:27.000000000 +1000
+++ linux-work/include/linux/netdevice.h 2007-10-16 15:27:38.000000000 +1000
@@ -394,6 +394,21 @@ static inline void napi_disable(struct n
}
/**
+ * __napi_synchronize - synchronize with a concurrent poll
+ * @n: napi context
+ *
+ * Synchronizes with a concurrent poll. Not to be used in normal
+ * drivers, mostly useful if you end up with multiple interfaces
+ * on one NAPI instance.
+ */
+static inline void __napi_synchronize(struct napi_struct *n)
+{
+ smp_mb();
+ while (test_bit(NAPI_STATE_SCHED, &n->state))
+ msleep_interruptible(1);
+}
+
+/**
* napi_enable - enable NAPI scheduling
* @n: napi context
*
next reply other threads:[~2007-10-16 5:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-16 5:49 Benjamin Herrenschmidt [this message]
2007-10-16 6:06 ` [PATCH/RFC] net: Add __napi_sycnhronize() to sync with napi poll Herbert Xu
2007-10-16 7:37 ` Benjamin Herrenschmidt
2007-10-16 7:44 ` David Miller
2007-10-16 18:53 ` Stephen Hemminger
2007-10-16 21:14 ` Benjamin Herrenschmidt
2007-10-17 2:50 ` Benjamin Herrenschmidt
2007-10-17 2:52 ` Benjamin Herrenschmidt
2007-10-17 3:16 ` Jeff Garzik
2007-10-17 3:24 ` Benjamin Herrenschmidt
2007-10-17 15:31 ` Stephen Hemminger
2007-10-17 21:52 ` Benjamin Herrenschmidt
2007-10-17 22:04 ` [PATCH] net: Add napi_sycnhronize() " Benjamin Herrenschmidt
2007-10-17 23:36 ` Josh Boyer
2007-10-17 23:59 ` Benjamin Herrenschmidt
2007-10-18 1:02 ` Josh Boyer
2007-10-18 1:26 ` Benjamin Herrenschmidt
2007-10-18 1:19 ` Benjamin Herrenschmidt
2007-10-17 23:14 ` [PATCH] fix EMAC driver for proper napi_synchronize API Benjamin Herrenschmidt
2007-10-18 0:21 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2007-10-16 5:40 [PATCH/RFC] net: Add __napi_sycnhronize() to sync with napi poll Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1192513792.19073.23.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).