From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 4C18CDDE38 for ; Wed, 17 Oct 2007 11:47:13 +1000 (EST) Subject: Re: [PATCH] net: Fix new EMAC driver for NAPI changes From: Benjamin Herrenschmidt To: Jeff Garzik In-Reply-To: <47156258.5010800@garzik.org> References: <1192513250.19073.10.camel@pasglop> <47156258.5010800@garzik.org> Content-Type: text/plain Date: Wed, 17 Oct 2007 11:46:54 +1000 Message-Id: <1192585614.11899.108.camel@pasglop> Mime-Version: 1.0 Cc: linuxppc-dev list , netdev@vger.kernel.org, Roland Dreier , "David S. Miller" , shemminger@linux.foundation.org Reply-To: benh@kernel.crashing.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2007-10-16 at 21:16 -0400, Jeff Garzik wrote: > Benjamin Herrenschmidt wrote: > > net: Fix new EMAC driver for NAPI changes > > > > This fixes the new EMAC driver for the NAPI updates. The previous patch > > by Roland Dreier (already applied) to do that doesn't actually work. This > > applies on top of it makes it work on my test Ebony machine. > > > > This patch depends on "net: Add __napi_sycnhronize() to sync with napi poll" > > posted previously. > > > > Signed-off-by: Benjamin Herrenschmidt > > --- > > > > The old EMAC driver does things a bit differently (doesn't do useful > > locking :-) and seems to work with Roland patch. So I'm not going to > > touch it unless somebody reports me that it has problems > > applied Beware that the depend patch for __napi_synchronize() is still being discussed :-) Cheers, Ben.