From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
To: benh@kernel.crashing.org
Cc: Jeff Garzik <jeff@garzik.org>,
netdev@vger.kernel.org, Roland Dreier <rdreier@cisco.com>,
linuxppc-dev list <linuxppc-dev@ozlabs.org>,
Stephen Hemminger <shemminger@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] net: Add napi_sycnhronize() to sync with napi poll
Date: Wed, 17 Oct 2007 18:36:23 -0500 [thread overview]
Message-ID: <1192664183.13993.30.camel@localhost.localdomain> (raw)
In-Reply-To: <1192658654.6783.43.camel@pasglop>
On Thu, 2007-10-18 at 08:04 +1000, Benjamin Herrenschmidt wrote:
> net: Add __napi_synchronize() to sync with napi poll
>
> The EMAC driver which needs to handle multiple devices with one
> NAPI instance implements its own per-channel disable bit. However,
> when setting such a bit, it needs to synchronize with the poller
> (that is make sure that any pending poller instance has completed,
> or is started late enough to see that disable bit).
>
> This implements a low level __napi_synchronize() function to acheive
> that. The underscores are to emphasis the low level aspect of it and
> to discourage driver writers who don't know what they are doing to
> use it (to please DaveM :-)
Erm.. your commit log calls it __napi_synchronize still.
josh
next prev parent reply other threads:[~2007-10-17 23:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-16 5:49 [PATCH/RFC] net: Add __napi_sycnhronize() to sync with napi poll Benjamin Herrenschmidt
2007-10-16 6:06 ` Herbert Xu
2007-10-16 7:37 ` Benjamin Herrenschmidt
2007-10-16 7:44 ` David Miller
2007-10-16 18:53 ` Stephen Hemminger
2007-10-16 21:14 ` Benjamin Herrenschmidt
2007-10-17 2:50 ` Benjamin Herrenschmidt
2007-10-17 2:52 ` Benjamin Herrenschmidt
2007-10-17 3:16 ` Jeff Garzik
2007-10-17 3:24 ` Benjamin Herrenschmidt
2007-10-17 15:31 ` Stephen Hemminger
2007-10-17 21:52 ` Benjamin Herrenschmidt
2007-10-17 22:04 ` [PATCH] net: Add napi_sycnhronize() " Benjamin Herrenschmidt
2007-10-17 23:36 ` Josh Boyer [this message]
2007-10-17 23:59 ` Benjamin Herrenschmidt
2007-10-18 1:02 ` Josh Boyer
2007-10-18 1:26 ` Benjamin Herrenschmidt
2007-10-18 1:19 ` Benjamin Herrenschmidt
2007-10-17 23:14 ` [PATCH] fix EMAC driver for proper napi_synchronize API Benjamin Herrenschmidt
2007-10-18 0:21 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1192664183.13993.30.camel@localhost.localdomain \
--to=jwboyer@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).