From: Michael Ellerman <michael@ellerman.id.au>
To: benh@kernel.crashing.org
Cc: linuxppc-dev@ozlabs.org, jgarzik@pobox.com
Subject: Re: [PATCH] Use of_get_next_child() in k2_sata_proc_info()
Date: Wed, 24 Oct 2007 15:31:25 +1000 [thread overview]
Message-ID: <1193203885.8788.6.camel@concordia> (raw)
In-Reply-To: <1193202117.2085.45.camel@pasglop>
[-- Attachment #1: Type: text/plain, Size: 845 bytes --]
On Wed, 2007-10-24 at 15:01 +1000, Benjamin Herrenschmidt wrote:
> On Wed, 2007-10-24 at 14:25 +1000, Michael Ellerman wrote:
> > k2_sata_proc_info() uses its own hand-rolled loop to check a nodes
> > children for a property, this is not safe WRT refcounting, so fix it
> > to use of_get_next_child().
> >
> > Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
>
> Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>
> (Pending you test boot it on one of our G5s first !)
As if I'd send untested patches !!
...
It just booted and seems happy.
cheers
--
Michael Ellerman
OzLabs, IBM Australia Development Lab
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-10-24 5:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 4:25 [PATCH] Use of_get_next_child() in k2_sata_proc_info() Michael Ellerman
2007-10-24 5:01 ` Benjamin Herrenschmidt
2007-10-24 5:31 ` Michael Ellerman [this message]
2007-10-24 6:04 ` Jeff Garzik
2007-10-24 6:23 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1193203885.8788.6.camel@concordia \
--to=michael@ellerman.id.au \
--cc=benh@kernel.crashing.org \
--cc=jgarzik@pobox.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox