From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Olof Johansson <olof@lixom.net>
Cc: linuxppc-dev@ozlabs.org, Will Schmidt <will_schmidt@vnet.ibm.com>,
paulus@samba.org
Subject: Re: [PATCH] [powerpc] update xmon slb code
Date: Tue, 30 Oct 2007 10:17:15 +1100 [thread overview]
Message-ID: <1193699835.9928.45.camel@pasglop> (raw)
In-Reply-To: <20071029205254.GA27544@lixom.net>
> Nice, I like it! I wonder if it would make sense to (space) pad the
> ESID/VSID fields so they line up, it'd make output just a little tidier.
>
> (If you end up changing that, please also break the long printf lines
> in two.)
>
> Beside that it looks good to me! :)
Can you also print out the LLP bits ? (I won't ask you to also decode
the page size though that would be useful :-)
Cheers,
Ben.
prev parent reply other threads:[~2007-10-29 23:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-29 19:59 [PATCH] [powerpc] update xmon slb code Will Schmidt
2007-10-29 20:52 ` Olof Johansson
2007-10-29 23:17 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1193699835.9928.45.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=olof@lixom.net \
--cc=paulus@samba.org \
--cc=will_schmidt@vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).