From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [RFC/PATCH] powerpc: Deal with 44x virtually tagged icache
Date: Wed, 31 Oct 2007 07:16:31 +1100 [thread overview]
Message-ID: <1193775391.9928.78.camel@pasglop> (raw)
In-Reply-To: <20071030072310.51870c65@weaponx.rchland.ibm.com>
> > Fortunately, we don't support SMP on these or this solution wouldn't
> > work.
>
> We should mark 44x BROKEN on SMP in Kconfig.
Can we enable SMP on 44x at all currently ?
> No arch/ppc fix? I know we all want it to die as soon as possible, but
> still... :)
Yeah, I didn't do it yet, which is one reason this patch is marked
RFC :-)
> > /* interrupts are hard-disabled at this point */
> > restore:
> > +#ifdef CONFIG_44x
> > + lis r4,icache_44x_need_flush@ha
> > + lwz r5,icache_44x_need_flush@l(r4)
> > + cmplwi cr0,r5,0
> > + beq+ 1f
> > + iccci r0,r0
> > + li r6,0
> > + iccci r0,r0
> > + stw r6,icache_44x_need_flush@l(r4)
> > +1:
>
> Why two iccci's here?
No idea... thinko/typo.
Ben.
next prev parent reply other threads:[~2007-10-30 20:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-30 5:16 [RFC/PATCH] powerpc: Deal with 44x virtually tagged icache Benjamin Herrenschmidt
2007-10-30 12:23 ` Josh Boyer
2007-10-30 20:16 ` Benjamin Herrenschmidt [this message]
2007-10-30 21:07 ` Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1193775391.9928.78.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).