From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Stefan Roese <sr@denx.de>
Cc: netdev@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] net: Add 405EX support to new EMAC driver
Date: Fri, 02 Nov 2007 07:37:01 +1100 [thread overview]
Message-ID: <1193949421.6541.10.camel@pasglop> (raw)
In-Reply-To: <200711011554.04935.sr@denx.de>
On Thu, 2007-11-01 at 15:54 +0100, Stefan Roese wrote:
> This patch adds support for the 405EX to the new EMAC driver.
>
> Tested on AMCC Kilauea.
.../...
> diff --git a/drivers/net/ibm_newemac/rgmii.c b/drivers/net/ibm_newemac/rgmii.c
> index de41695..e393f68 100644
> --- a/drivers/net/ibm_newemac/rgmii.c
> +++ b/drivers/net/ibm_newemac/rgmii.c
> @@ -140,9 +140,6 @@ void rgmii_get_mdio(struct of_device *ofdev, int input)
>
> RGMII_DBG2(dev, "get_mdio(%d)" NL, input);
>
> - if (dev->type != RGMII_AXON)
> - return;
> -
> mutex_lock(&dev->lock);
That will break 440GX boards that need to use the RGMII for data and the
ZMII for MDIO.
You may want to change the name RGMII_AXON something like RGMII_HAS_MDIO
instead and set that for 405EX as well instead.
Ben.
next prev parent reply other threads:[~2007-11-01 20:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-01 14:54 [PATCH] net: Add 405EX support to new EMAC driver Stefan Roese
2007-11-01 20:37 ` Benjamin Herrenschmidt [this message]
2007-11-01 21:07 ` Josh Boyer
2007-11-01 21:31 ` Stefan Roese
-- strict thread matches above, loose matches on Subject: below --
2007-11-02 7:14 Stefan Roese
2007-11-02 16:03 ` Olof Johansson
2007-11-04 3:37 ` Benjamin Herrenschmidt
2007-11-04 17:16 ` Olof Johansson
2007-11-05 9:19 ` Stefan Roese
2007-11-05 11:04 ` Benjamin Herrenschmidt
2007-11-05 11:11 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1193949421.6541.10.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).