From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <benh@kernel.crashing.org>
Subject: Re: pcspkr device, pnpPNP,100
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jon Smirl <jonsmirl@gmail.com>
In-Reply-To: <9e4733910711111607i35294d3ja43e1c616a3427bd@mail.gmail.com>
References: <9e4733910711111535w6ffdfa97x4bed07eb84d4ab13@mail.gmail.com>
	<1194825784.18185.0.camel@pasglop>
	<9e4733910711111607i35294d3ja43e1c616a3427bd@mail.gmail.com>
Content-Type: text/plain
Date: Mon, 12 Nov 2007 11:09:51 +1100
Message-Id: <1194826191.18185.6.camel@pasglop>
Mime-Version: 1.0
Cc: PowerPC dev list <Linuxppc-dev@ozlabs.org>
Reply-To: benh@kernel.crashing.org
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.ozlabs.org>
List-Unsubscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=unsubscribe>
List-Archive: <http://ozlabs.org/pipermail/linuxppc-dev>
List-Post: <mailto:linuxppc-dev@ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@ozlabs.org?subject=help>
List-Subscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=subscribe>


On Sun, 2007-11-11 at 19:07 -0500, Jon Smirl wrote:
> 
> This code should be in a device driver so that it can be selected with
> Kconfig. Can we #ifdef it now as a hint? I could make it a device
> driver but I don't have any hardware to test it on.
> 
> I'm trying to get the mpc5200 kernel to build with platform bus turned
> off (only of_platform bus). I'm almost there, just a couple more odd
> places to patch up.

Just don't do platform ifdef's, ever.

What you can do however is Kconfig options that get selected by
platforms that need a given service, and then use that as an ifdef for
that service.

A bit like how we select what interrupt controller drivers to built-in
for example.

Ben.