From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jon Smirl <jonsmirl@gmail.com>
Cc: PowerPC dev list <Linuxppc-dev@ozlabs.org>
Subject: Re: Gianfar ethernet device
Date: Mon, 12 Nov 2007 12:08:00 +1100 [thread overview]
Message-ID: <1194829680.18185.10.camel@pasglop> (raw)
In-Reply-To: <9e4733910711111622v5ad6fdd2jd30989819d05615d@mail.gmail.com>
> The real solution is that gianfar support belongs in a device driver,
> not in a common file. That whole fsl_soc.c file is a catch-all of
> things that belong in device drivers. I haven't looked at every line
> in it, but 90%+ of the code should be moved into device drivers.
>
> I'm preparing a patch that moves the i2c driver out of fsl_soc.c and
> into i2c_mpc.c.
The problem is how do you instanciate it. I'm working on some solution
for that but it's not there yet.
Ben.
next prev parent reply other threads:[~2007-11-12 1:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-11 23:11 Gianfar ethernet device Jon Smirl
2007-11-11 23:30 ` Jon Smirl
2007-11-12 0:04 ` Benjamin Herrenschmidt
2007-11-12 0:22 ` Jon Smirl
2007-11-12 0:30 ` Jon Smirl
2007-11-12 1:08 ` Benjamin Herrenschmidt [this message]
2007-11-12 1:16 ` Jon Smirl
2007-11-12 2:03 ` Benjamin Herrenschmidt
2007-11-12 21:25 ` Jon Smirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1194829680.18185.10.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=Linuxppc-dev@ozlabs.org \
--cc=jonsmirl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).