From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 66F66DDE26 for ; Tue, 13 Nov 2007 07:57:12 +1100 (EST) Subject: Re: [linux-pm] Re: [RFC] powermac: proper sleep management From: Benjamin Herrenschmidt To: Alan Stern In-Reply-To: References: Content-Type: text/plain Date: Tue, 13 Nov 2007 07:56:38 +1100 Message-Id: <1194900998.18185.57.camel@pasglop> Mime-Version: 1.0 Cc: linuxppc-dev list , Johannes Berg , David Woodhouse , linux-pm Reply-To: benh@kernel.crashing.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2007-11-12 at 15:40 -0500, Alan Stern wrote: > On Tue, 13 Nov 2007, Benjamin Herrenschmidt wrote: > > > > > On Mon, 2007-11-12 at 17:32 +0100, Johannes Berg wrote: > > > > Looks good to me, +/- a couple of things: > > > > > > > > - We _REALLY_ want the freezer to be optional and not enabled by > > > > default on PowerPC. Maybe make it a compile option ? > > > > > > Well, Alan is going to tell you that USB will break. If we need > > > confirmation for that I can do the test he suggested to you or Paul a > > > while ago. > > > > Then USB is broken today on powermacs and need to be fixed. We had a > > clear agreement at KS this year that the freezer was at best a band-aid > > and that drivers -had- to be fixed to cope regardless. > > More accurately, freezing user tasks is at best a band-aid. However > some kernel threads do need to be frozen, and keeping the freezer > around for their use makes sense. It has less overhead -- I think > -- than adding new code to do the freezing in each of these threads. I remember fixing various issues so that khubd would be safe when non frozen (among other things) a while ago. Did you guys break it all again ? Ben.