From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Olof Johansson <olof@lixom.net>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: Fix 44x Machine Check handling
Date: Fri, 16 Nov 2007 18:41:08 +1100 [thread overview]
Message-ID: <1195198868.28865.142.camel@pasglop> (raw)
In-Reply-To: <20071116074025.GA4741@lixom.net>
On Fri, 2007-11-16 at 01:40 -0600, Olof Johansson wrote:
> I'm not sure I like this. It introduces another cpu feature flag,
> that we'll soon run out of if it's used to signify version info per
> implementation like this.
>
> 1) The SET_IVOR could be done from the cpu_setups for 440A instead
> (i.e. introduce one).
>
> 2) Please just move the machine check handlers out to individual ones
> instead of using the generic one. That way you don't need runtime checks
> between the two (they don't seem to share much of it as-is anyway).
>
> With the above two changes, you shouldn't need the feature bit any more.
We can easily make the cpu features bigger ... But ok, I'll have a look
at doing it the way you suggest.
Cheers,
Ben.
next prev parent reply other threads:[~2007-11-16 7:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-16 7:21 [PATCH] powerpc: Fix 44x Machine Check handling Benjamin Herrenschmidt
2007-11-16 7:40 ` Olof Johansson
2007-11-16 7:41 ` Benjamin Herrenschmidt [this message]
2007-11-16 7:45 ` Benjamin Herrenschmidt
2007-11-16 21:55 ` Kumar Gala
2007-11-17 17:09 ` Josh Boyer
2007-11-16 14:58 ` Josh Boyer
2007-11-16 21:03 ` Benjamin Herrenschmidt
2007-11-16 21:54 ` Kumar Gala
2007-11-16 22:21 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1195198868.28865.142.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).