* [PATCH] SET_NETDEV_DEV() in fec_mpc52xx.c
@ 2007-11-28 18:04 David Woodhouse
2007-11-28 19:56 ` [PATCH] Stop phy code from returning success to unknown ioctls David Woodhouse
2007-12-01 21:35 ` [PATCH] SET_NETDEV_DEV() in fec_mpc52xx.c Jeff Garzik
0 siblings, 2 replies; 5+ messages in thread
From: David Woodhouse @ 2007-11-28 18:04 UTC (permalink / raw)
To: jgarzik; +Cc: linuxppc-dev, Domen Puncer, netdev
This helps to allow the Fedora installer to use the built-in Ethernet on
the Efika for a network install.
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
--- a/drivers/net/fec_mpc52xx.c
+++ b/drivers/net/fec_mpc52xx.c
@@ -971,6 +971,8 @@ mpc52xx_fec_probe(struct of_device *op, const struct of_device_id *match)
mpc52xx_fec_reset_stats(ndev);
+ SET_NETDEV_DEV(ndev, &op->dev);
+
/* Register the new network device */
rv = register_netdev(ndev);
if (rv < 0)
--
dwmw2
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] Stop phy code from returning success to unknown ioctls.
2007-11-28 18:04 [PATCH] SET_NETDEV_DEV() in fec_mpc52xx.c David Woodhouse
@ 2007-11-28 19:56 ` David Woodhouse
2007-12-01 21:36 ` Jeff Garzik
2007-12-04 20:00 ` Andy Fleming
2007-12-01 21:35 ` [PATCH] SET_NETDEV_DEV() in fec_mpc52xx.c Jeff Garzik
1 sibling, 2 replies; 5+ messages in thread
From: David Woodhouse @ 2007-11-28 19:56 UTC (permalink / raw)
To: jgarzik; +Cc: linuxppc-dev, Domen Puncer, netdev
This kind of sucks, and prevents the Fedora installer from using the
device for network installs...
[root@efika phy]# iwconfig eth0
Warning: Driver for device eth0 has been compiled with an ancient version
of Wireless Extension, while this program support version 11 and later.
Some things may be broken...
eth0 ESSID:off/any Nickname:""
NWID:0 Channel:0 Access Point: 00:00:BF:81:14:E0
Bit Rate:-1.08206e+06 kb/s Sensitivity=0/0
RTS thr:off Fragment thr:off
Encryption key:<too big>
Power Management:off
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 9bc1177..7c9e6e3 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -406,6 +406,9 @@ int phy_mii_ioctl(struct phy_device *phydev,
&& phydev->drv->config_init)
phydev->drv->config_init(phydev);
break;
+
+ default:
+ return -ENOTTY;
}
return 0;
--
dwmw2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] Stop phy code from returning success to unknown ioctls.
2007-11-28 19:56 ` [PATCH] Stop phy code from returning success to unknown ioctls David Woodhouse
@ 2007-12-01 21:36 ` Jeff Garzik
2007-12-04 20:00 ` Andy Fleming
1 sibling, 0 replies; 5+ messages in thread
From: Jeff Garzik @ 2007-12-01 21:36 UTC (permalink / raw)
To: David Woodhouse; +Cc: linuxppc-dev, Domen Puncer, netdev
David Woodhouse wrote:
> This kind of sucks, and prevents the Fedora installer from using the
> device for network installs...
>
> [root@efika phy]# iwconfig eth0
> Warning: Driver for device eth0 has been compiled with an ancient version
> of Wireless Extension, while this program support version 11 and later.
> Some things may be broken...
>
> eth0 ESSID:off/any Nickname:""
> NWID:0 Channel:0 Access Point: 00:00:BF:81:14:E0
> Bit Rate:-1.08206e+06 kb/s Sensitivity=0/0
> RTS thr:off Fragment thr:off
> Encryption key:<too big>
> Power Management:off
>
> Signed-off-by: David Woodhouse <dwmw2@infradead.org>
>
> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
> index 9bc1177..7c9e6e3 100644
> --- a/drivers/net/phy/phy.c
> +++ b/drivers/net/phy/phy.c
> @@ -406,6 +406,9 @@ int phy_mii_ioctl(struct phy_device *phydev,
> && phydev->drv->config_init)
> phydev->drv->config_init(phydev);
> break;
> +
> + default:
> + return -ENOTTY;
> }
>
applied
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Stop phy code from returning success to unknown ioctls.
2007-11-28 19:56 ` [PATCH] Stop phy code from returning success to unknown ioctls David Woodhouse
2007-12-01 21:36 ` Jeff Garzik
@ 2007-12-04 20:00 ` Andy Fleming
1 sibling, 0 replies; 5+ messages in thread
From: Andy Fleming @ 2007-12-04 20:00 UTC (permalink / raw)
To: David Woodhouse; +Cc: linuxppc-dev, jgarzik, Domen Puncer, netdev
On Nov 28, 2007, at 13:56, David Woodhouse wrote:
> This kind of sucks, and prevents the Fedora installer from using the
> device for network installs...
>
> [root@efika phy]# iwconfig eth0
> Warning: Driver for device eth0 has been compiled with an ancient
> version
> of Wireless Extension, while this program support version 11 and
> later.
> Some things may be broken...
>
> eth0 ESSID:off/any Nickname:""
> NWID:0 Channel:0 Access Point: 00:00:BF:81:14:E0
> Bit Rate:-1.08206e+06 kb/s Sensitivity=0/0
> RTS thr:off Fragment thr:off
> Encryption key:<too big>
> Power Management:off
>
> Signed-off-by: David Woodhouse <dwmw2@infradead.org>
d'oh!
Acked-by: Andy Fleming <afleming@freescale.com>
>
> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
> index 9bc1177..7c9e6e3 100644
> --- a/drivers/net/phy/phy.c
> +++ b/drivers/net/phy/phy.c
> @@ -406,6 +406,9 @@ int phy_mii_ioctl(struct phy_device *phydev,
> && phydev->drv->config_init)
> phydev->drv->config_init(phydev);
> break;
> +
> + default:
> + return -ENOTTY;
> }
>
> return 0;
>
> --
> dwmw2
>
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] SET_NETDEV_DEV() in fec_mpc52xx.c
2007-11-28 18:04 [PATCH] SET_NETDEV_DEV() in fec_mpc52xx.c David Woodhouse
2007-11-28 19:56 ` [PATCH] Stop phy code from returning success to unknown ioctls David Woodhouse
@ 2007-12-01 21:35 ` Jeff Garzik
1 sibling, 0 replies; 5+ messages in thread
From: Jeff Garzik @ 2007-12-01 21:35 UTC (permalink / raw)
To: David Woodhouse; +Cc: linuxppc-dev, Domen Puncer, netdev
David Woodhouse wrote:
> This helps to allow the Fedora installer to use the built-in Ethernet on
> the Efika for a network install.
>
> Signed-off-by: David Woodhouse <dwmw2@infradead.org>
>
> --- a/drivers/net/fec_mpc52xx.c
> +++ b/drivers/net/fec_mpc52xx.c
> @@ -971,6 +971,8 @@ mpc52xx_fec_probe(struct of_device *op, const struct of_device_id *match)
>
> mpc52xx_fec_reset_stats(ndev);
>
> + SET_NETDEV_DEV(ndev, &op->dev);
> +
> /* Register the new network device */
> rv = register_netdev(ndev);
applied
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-12-04 20:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-28 18:04 [PATCH] SET_NETDEV_DEV() in fec_mpc52xx.c David Woodhouse
2007-11-28 19:56 ` [PATCH] Stop phy code from returning success to unknown ioctls David Woodhouse
2007-12-01 21:36 ` Jeff Garzik
2007-12-04 20:00 ` Andy Fleming
2007-12-01 21:35 ` [PATCH] SET_NETDEV_DEV() in fec_mpc52xx.c Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).