From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Brandeburg, Jesse" <jesse.brandeburg@intel.com>
Cc: netdev@vger.kernel.org, "Kok,
Auke-jan H" <auke-jan.h.kok@intel.com>,
Jeff Garzik <jeff@garzik.org>,
linuxppc-dev@ozlabs.org
Subject: RE: [PATCH] e1000: Fix for 32 bits platforms with 64 bits resources
Date: Thu, 29 Nov 2007 06:52:12 +1100 [thread overview]
Message-ID: <1196279532.13230.14.camel@pasglop> (raw)
In-Reply-To: <36D9DB17C6DE9E40B059440DB8D95F5203DF7871@orsmsx418.amr.corp.intel.com>
On Wed, 2007-11-28 at 10:47 -0800, Brandeburg, Jesse wrote:
>
> > The side effect is that I removed the assignments to the netdev
> > fields mem_start, mem_end and base_addr, which are totally useless
> > for PCI devices.
>
> also, concerning this, ifconfig shows the output of these variables, I
> don't think we want to blatantly remove them, as it is actually removing
> information that is, if not used, at least displayed to user space.
It's not the right place to have that information and there is no
room in the user space field to fit more than 32 bits on 32 bits
platforms so I'd rather remove it. It's really only for ISA drivers that
have user configurable addresses.
Ben.
next prev parent reply other threads:[~2007-11-28 19:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-16 7:37 [PATCH] e1000: Fix for 32 bits platforms with 64 bits resources Benjamin Herrenschmidt
2007-11-24 2:52 ` Jeff Garzik
2007-11-26 23:15 ` Kok, Auke
2007-11-28 18:47 ` Brandeburg, Jesse
2007-11-28 19:52 ` Benjamin Herrenschmidt [this message]
2008-02-06 12:13 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1196279532.13230.14.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=auke-jan.h.kok@intel.com \
--cc=jeff@garzik.org \
--cc=jesse.brandeburg@intel.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).