linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: jgarzik@pobox.com
Cc: linuxppc-dev@ozlabs.org, Domen Puncer <domen.puncer@telargo.com>,
	netdev@vger.kernel.org
Subject: [PATCH] Stop phy code from returning success to unknown ioctls.
Date: Wed, 28 Nov 2007 19:56:34 +0000	[thread overview]
Message-ID: <1196279794.30806.54.camel@pmac.infradead.org> (raw)
In-Reply-To: <1196273071.30806.46.camel@pmac.infradead.org>

This kind of sucks, and prevents the Fedora installer from using the
device for network installs...

[root@efika phy]# iwconfig eth0                                                                                                                
Warning: Driver for device eth0 has been compiled with an ancient version                                                                      
of Wireless Extension, while this program support version 11 and later.                                                                        
Some things may be broken...                                                                                                                   
                                                                                                                                               
eth0        ESSID:off/any  Nickname:""                                                                                                         
          NWID:0  Channel:0  Access Point: 00:00:BF:81:14:E0                                                                                   
          Bit Rate:-1.08206e+06 kb/s   Sensitivity=0/0                                                                                         
          RTS thr:off   Fragment thr:off                                                                                                       
          Encryption key:<too big>                                                                                                             
          Power Management:off                                                                                                                 
                                                                                                                                               
Signed-off-by: David Woodhouse <dwmw2@infradead.org>

diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 9bc1177..7c9e6e3 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -406,6 +406,9 @@ int phy_mii_ioctl(struct phy_device *phydev,
 				&& phydev->drv->config_init)
 			phydev->drv->config_init(phydev);
 		break;
+
+	default:
+		return -ENOTTY;
 	}
 
 	return 0;

-- 
dwmw2

  reply	other threads:[~2007-11-28 19:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-28 18:04 [PATCH] SET_NETDEV_DEV() in fec_mpc52xx.c David Woodhouse
2007-11-28 19:56 ` David Woodhouse [this message]
2007-12-01 21:36   ` [PATCH] Stop phy code from returning success to unknown ioctls Jeff Garzik
2007-12-04 20:00   ` Andy Fleming
2007-12-01 21:35 ` [PATCH] SET_NETDEV_DEV() in fec_mpc52xx.c Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1196279794.30806.54.camel@pmac.infradead.org \
    --to=dwmw2@infradead.org \
    --cc=domen.puncer@telargo.com \
    --cc=jgarzik@pobox.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).