From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 43982DDEB6 for ; Fri, 30 Nov 2007 07:55:14 +1100 (EST) Subject: Re: [PATCH 5/5] PPC cleanup: powermac - do use for_each macro From: Benjamin Herrenschmidt To: Cyrill Gorcunov In-Reply-To: <20071129194654.GF12123@cvg> References: <20071129194654.GF12123@cvg> Content-Type: text/plain Date: Fri, 30 Nov 2007 07:54:59 +1100 Message-Id: <1196369699.13230.62.camel@pasglop> Mime-Version: 1.0 Cc: PPCML , Paul Mackerras , LKML Reply-To: benh@kernel.crashing.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 2007-11-29 at 22:46 +0300, Cyrill Gorcunov wrote: > From: Cyrill Gorcunov > > Signed-off-by: Cyrill Gorcunov > --- Ack. > arch/powerpc/platforms/powermac/low_i2c.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/platforms/powermac/low_i2c.c b/arch/powerpc/platforms/powermac/low_i2c.c > index da2007e..864fbf4 100644 > --- a/arch/powerpc/platforms/powermac/low_i2c.c > +++ b/arch/powerpc/platforms/powermac/low_i2c.c > @@ -585,8 +585,7 @@ static void __init kw_i2c_probe(void) > struct device_node *np, *child, *parent; > > /* Probe keywest-i2c busses */ > - for (np = NULL; > - (np = of_find_compatible_node(np, "i2c","keywest-i2c")) != NULL;){ > + for_each_compatible_node(np, "i2c","keywest-i2c") { > struct pmac_i2c_host_kw *host; > int multibus, chans, i; >