From: Li Li <r64360@freescale.com>
To: Olof Johansson <olof@lixom.net>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>,
Gala Kumar <kumar.gala@freescale.com>,
Li Tony <Tony.Li@freescale.com>
Subject: Re: [PATCH] Add MPC837xEMDS PCIE RC mode support
Date: Fri, 30 Nov 2007 13:33:53 +0800 [thread overview]
Message-ID: <1196400833.31368.2.camel@Guyver> (raw)
In-Reply-To: <20071130041404.GB26982@lixom.net>
On Fri, 2007-11-30 at 12:14 +0800, Olof Johansson wrote:
> Hi,
>
> On Fri, Nov 30, 2007 at 11:45:34AM +0800, Li Li wrote:
>
> > + pci2@e0009000 {
>
> Why call it pci2@ (and pci3@ below)? They are clearly identifiable
> with
> their unit addresses anyway.
>
> > +config PPC_MPC83XX_PCIE
> > + bool "MPC837X PCI Express support"
> > + depends on PCIEPORTBUS && PPC_MPC837x
> > + default n
> > + help
> > + Enables MPC837x PCI express RC mode
>
> Why have a separate config option for this?
>
> For systems where you don't want PCI-e configured, it should be left
> out of the device tree instead.
It is easy to configure kernel than modify and recompile the dts.
The pcie is default enabled in dts.
>
>
>
> -Olof
>
- Tony
next prev parent reply other threads:[~2007-11-30 5:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-30 3:45 [PATCH] Add MPC837xEMDS PCIE RC mode support Li Li
2007-11-30 4:14 ` Olof Johansson
2007-11-30 5:33 ` Li Li [this message]
2007-11-30 15:12 ` Scott Wood
2007-11-30 7:37 ` Kumar Gala
2007-11-30 8:48 ` Li Li
2007-11-30 9:05 ` Kumar Gala
2007-11-30 9:37 ` Li Li
2007-11-30 14:57 ` Kumar Gala
2007-11-30 15:19 ` Scott Wood
2007-12-03 3:43 ` Li Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1196400833.31368.2.camel@Guyver \
--to=r64360@freescale.com \
--cc=Tony.Li@freescale.com \
--cc=kumar.gala@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).