From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Li Yang <LeoLi@freescale.com>
Cc: linuxppc-dev@ozlabs.org
Subject: RE: [PATCH] ipic: change ack operation that register is accessedonly when needed
Date: Tue, 04 Dec 2007 13:15:56 +1100 [thread overview]
Message-ID: <1196734556.13230.258.camel@pasglop> (raw)
In-Reply-To: <989B956029373F45A0B8AF029708189001B4D2DE@zch01exm26.fsl.freescale.net>
On Tue, 2007-12-04 at 10:06 +0800, Li Yang wrote:
> > That should be handled by the higher level flow handler. The
> > generic edge one calls ack and the level one mask_and_ack.
> > Just make them do the right thing, no need to test for the
> > flow type in the low level function.
>
> But actually ack is called by edge and per cpu handlers. Mask_and_ack
> is also called by edge handler when the same interrupt is already in
> progress. So I don't think that ack/mask_and_ack implicates flow type
> by design.
They do and you can pass different irq_chip with different mask/ack
routines if necessary.
Ben.
next prev parent reply other threads:[~2007-12-04 2:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-03 12:26 [PATCH] ipic: change ack operation that register is accessed only when needed Li Yang
2007-12-03 12:26 ` [PATCH] add MPC837x MDS default kernel configuration Li Yang
2007-12-03 21:02 ` [PATCH] ipic: change ack operation that register is accessed only when needed Benjamin Herrenschmidt
2007-12-04 2:06 ` [PATCH] ipic: change ack operation that register is accessedonly " Li Yang
2007-12-04 2:15 ` Benjamin Herrenschmidt [this message]
2007-12-04 7:23 ` [PATCH] ipic: change ack operation that register isaccessedonly " Li Yang
2007-12-04 7:39 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1196734556.13230.258.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=LeoLi@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).