From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 1D2F9DDE3B for ; Tue, 4 Dec 2007 13:16:32 +1100 (EST) Subject: RE: [PATCH] ipic: change ack operation that register is accessedonly when needed From: Benjamin Herrenschmidt To: Li Yang In-Reply-To: <989B956029373F45A0B8AF029708189001B4D2DE@zch01exm26.fsl.freescale.net> References: <1196684780-28408-1-git-send-email-leoli@freescale.com> <1196715747.13230.233.camel@pasglop> <989B956029373F45A0B8AF029708189001B4D2DE@zch01exm26.fsl.freescale.net> Content-Type: text/plain Date: Tue, 04 Dec 2007 13:15:56 +1100 Message-Id: <1196734556.13230.258.camel@pasglop> Mime-Version: 1.0 Cc: linuxppc-dev@ozlabs.org Reply-To: benh@kernel.crashing.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2007-12-04 at 10:06 +0800, Li Yang wrote: > > That should be handled by the higher level flow handler. The > > generic edge one calls ack and the level one mask_and_ack. > > Just make them do the right thing, no need to test for the > > flow type in the low level function. > > But actually ack is called by edge and per cpu handlers. Mask_and_ack > is also called by edge handler when the same interrupt is already in > progress. So I don't think that ack/mask_and_ack implicates flow type > by design. They do and you can pass different irq_chip with different mask/ack routines if necessary. Ben.