From: Li Li <r64360@freescale.com>
To: benh@kernel.crashing.org
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>,
Gala Kumar <kumar.gala@freescale.com>,
Li Tony <Tony.Li@freescale.com>
Subject: Re: [PATCH] Add IPIC MSI interrupt support
Date: Tue, 04 Dec 2007 17:10:10 +0800 [thread overview]
Message-ID: <1196759410.28693.5.camel@Guyver> (raw)
In-Reply-To: <1196754717.13230.286.camel@pasglop>
Yes. According to the PCI spec, a PCI device can request multi MSI
interrupts and require that interrupts are consecutive.
But it is ok if only allocate one to it.
Anyway, the hwirq should be allocated from bitmap instead of increment
by hand.
I will correct this and resend the patch.
- Tony
On Tue, 2007-12-04 at 15:51 +0800, Benjamin Herrenschmidt wrote:
> > I'm not sure what you mean? For MSI there is only one MSI per
> device,
> > but this code is used also for MSI-X which supports > 1 MSI per
> device.
>
> Or more specifically, for MSI, -linux- supports only one per device
> (in
> theory, it's possible to have multiple MSI non-X but it's a mess).
>
> > Either way we shouldn't be incrementing hwirq by hand, it's
> reassigned
> > at the top of the loop. I think that's left over from old code that
> > allocated nvec hwirqs in a block and then created virq mappings for
> each
> > one, whereas the new code allocates each hwirq separately.
> >
> > cheers
> >
> > _______________________________________________
> > Linuxppc-dev mailing list
> > Linuxppc-dev@ozlabs.org
> > https://ozlabs.org/mailman/listinfo/linuxppc-dev
>
next prev parent reply other threads:[~2007-12-04 9:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-30 3:48 [PATCH] Add IPIC MSI interrupt support Li Li
2007-12-03 1:52 ` David Gibson
2007-12-03 4:59 ` Li Li
2007-12-03 4:02 ` Michael Ellerman
2007-12-03 9:07 ` Li Li
2007-12-03 21:03 ` Benjamin Herrenschmidt
2007-12-04 1:41 ` Li Li
2007-12-04 5:38 ` Michael Ellerman
2007-12-04 7:51 ` Benjamin Herrenschmidt
2007-12-04 9:10 ` Li Li [this message]
2007-12-04 10:34 ` Li Tony
2007-12-04 12:04 ` Michael Ellerman
2007-12-04 13:13 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1196759410.28693.5.camel@Guyver \
--to=r64360@freescale.com \
--cc=Tony.Li@freescale.com \
--cc=benh@kernel.crashing.org \
--cc=kumar.gala@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).