linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Olof Johansson <olof@lixom.net>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 2/2] [POWERPC] pasemi: Register i2c_board_info
Date: Tue, 04 Dec 2007 13:28:46 +0000	[thread overview]
Message-ID: <1196774926.13978.225.camel@pmac.infradead.org> (raw)
In-Reply-To: <20071130032923.GB25580@lixom.net>


On Thu, 2007-11-29 at 21:29 -0600, Olof Johansson wrote:
> +                               continue;
> +
> +                       info.addr = *addr;
> +
> +                       i2c_register_board_info(PCI_FUNC(pdev->devfn),
> &info,
> +                                               1);
> +               }
> +       }

+       /* Ensure that buses up to 2 are reserved */
+       i2c_register_board_info(2, NULL, 0);
+


> +       return 0;
> +}
> +device_initcall(pasemi_register_i2c_devices);
> +#endif


Otherwise when you make i2c-pasemi use i2c_add_numbered_adapter(), it
might fail to register the third bus -- because there were no devices
preregistered on it, so something else might have stolen that bus number
already.

You might want to add the patch to use i2c_add_numbered_adapter() to
your tree, btw.

-- 
dwmw2

  reply	other threads:[~2007-12-04 13:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-30  3:26 [PATCH 1/2] [POWERPC] Consolidate compatible-to-i2c_boardinfo mapping code Olof Johansson
2007-11-30  3:29 ` [PATCH 2/2] [POWERPC] pasemi: Register i2c_board_info Olof Johansson
2007-12-04 13:28   ` David Woodhouse [this message]
2007-12-04 19:32     ` Olof Johansson
2007-12-05  0:41       ` Paul Mackerras
2007-12-05  2:09         ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1196774926.13978.225.camel@pmac.infradead.org \
    --to=dwmw2@infradead.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=olof@lixom.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).