From: Michael Ellerman <michael@ellerman.id.au>
To: Greg KH <greg@kroah.com>
Cc: linuxppc-dev@ozlabs.org, "Kyle A. Lucke" <klucke@us.ibm.com>,
paulus@samba.org, linux-kernel@vger.kernel.org,
David Gibson <dwg@au1.ibm.com>
Subject: Re: drivers/net/iseries_veth.c dubious sysfs usage
Date: Wed, 05 Dec 2007 22:10:31 +1100 [thread overview]
Message-ID: <1196853031.6759.7.camel@concordia> (raw)
In-Reply-To: <20071205093054.GA23229@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 1087 bytes --]
On Wed, 2007-12-05 at 01:30 -0800, Greg KH wrote:
> In doing a massive kobject cleanup of the kernel tree, I ran across the
> iseries_veth.c driver.
>
> It looks like the driver is creating a number of subdirectories under
> the driver sysfs directory. This is odd and probably wrong. You want
> these virtual connections to show up in the main sysfs device tree, not
> under the driver directory.
>
> I'll be glad to totally guess and try to move it around in the sysfs
> tree, but odds are I'll get it all wrong as I can't really test this
> out :)
>
> Any hints on what this driver is trying to do in this sysfs directories?
I wrote the code, I think, but it's been a while - I'll have a look at
it tomorrow.
Why is it "odd and probably wrong" to create subdirectories under the
driver in sysfs?
cheers
--
Michael Ellerman
OzLabs, IBM Australia Development Lab
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-12-05 11:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-05 9:30 drivers/net/iseries_veth.c dubious sysfs usage Greg KH
2007-12-05 11:10 ` Michael Ellerman [this message]
2007-12-05 21:41 ` Greg KH
2007-12-06 3:48 ` Michael Ellerman
2007-12-11 23:56 ` [PATCH] Introduce driver_create/remove_dir Stephen Rothwell
2007-12-12 0:40 ` Randy Dunlap
2007-12-12 2:36 ` Stephen Rothwell
2007-12-13 7:10 ` Greg KH
2007-12-13 7:08 ` drivers/net/iseries_veth.c dubious sysfs usage Greg KH
2007-12-24 2:52 ` Stephen Rothwell
2007-12-24 5:01 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1196853031.6759.7.camel@concordia \
--to=michael@ellerman.id.au \
--cc=dwg@au1.ibm.com \
--cc=greg@kroah.com \
--cc=klucke@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).