[DTC][PATCH] Fix cross-compile building

[DTC][PATCH] Fix cross-compile building

[Kumar Gala]

From: Stuart Hughes <stuarth@freescale.com>

This patch allows you to build the DTC source without making the
tests directory.  This is necessary when cross compiling as the
dumptest (and other) files cannot be run/used on the host system.
To use this use: 'make TESTS='

Signed-off-by: Stuart Hughes <stuarth@freescale.com>
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
 Makefile |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index bcb143f..9d926b5 100644
--- a/Makefile
+++ b/Makefile
@@ -46,7 +46,9 @@ else
 DEPTARGETS = $(filter-out $(NODEPTARGETS),$(MAKECMDGOALS))
 endif

-all: dtc ftdump libfdt tests
+TESTS = tests
+
+all: dtc ftdump libfdt $(TESTS)

 install: all
 	@$(VECHO) INSTALL
-- 
1.5.3.4

Re: [DTC][PATCH] Fix cross-compile building

[David Gibson]

On Fri, Dec 07, 2007 at 12:28:20PM -0600, Kumar Gala wrote:
> From: Stuart Hughes <stuarth@freescale.com>
> 
> This patch allows you to build the DTC source without making the
> tests directory.  This is necessary when cross compiling as the
> dumptest (and other) files cannot be run/used on the host system.
> To use this use: 'make TESTS='

I think this is a silly way of doing this.  Instead create a new
target which builds everything but the tests.

Say,

	all: cross tests

	cross: dtc ftdump libfdt

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Re: [DTC][PATCH] Fix cross-compile building

[Stuart Hughes]

On Sat, 2007-12-08 at 11:36 +1100, David Gibson wrote:
> On Fri, Dec 07, 2007 at 12:28:20PM -0600, Kumar Gala wrote:
> > From: Stuart Hughes <stuarth@freescale.com>
> > 
> > This patch allows you to build the DTC source without making the
> > tests directory.  This is necessary when cross compiling as the
> > dumptest (and other) files cannot be run/used on the host system.
> > To use this use: 'make TESTS='
> 
> I think this is a silly way of doing this.  Instead create a new
> target which builds everything but the tests.
> 
> Say,
> 
> 	all: cross tests
> 
> 	cross: dtc ftdump libfdt
> 

Works for me.

Regards, Stuart

Re: [DTC][PATCH] Fix cross-compile building

[Kumar Gala]

On Dec 7, 2007, at 6:36 PM, David Gibson wrote:

> On Fri, Dec 07, 2007 at 12:28:20PM -0600, Kumar Gala wrote:
>> From: Stuart Hughes <stuarth@freescale.com>
>>
>> This patch allows you to build the DTC source without making the
>> tests directory.  This is necessary when cross compiling as the
>> dumptest (and other) files cannot be run/used on the host system.
>> To use this use: 'make TESTS='
>
> I think this is a silly way of doing this.  Instead create a new
> target which builds everything but the tests.
>
> Say,
>
> 	all: cross tests
>
> 	cross: dtc ftdump libfdt

shouldn't we do this the other way around, it seems odd to build the  
tests always or at least as part of the all target.

- k

Re: [DTC][PATCH] Fix cross-compile building

[David Gibson]

On Thu, Dec 13, 2007 at 11:57:48PM -0600, Kumar Gala wrote:
> 
> On Dec 7, 2007, at 6:36 PM, David Gibson wrote:
> 
> > On Fri, Dec 07, 2007 at 12:28:20PM -0600, Kumar Gala wrote:
> >> From: Stuart Hughes <stuarth@freescale.com>
> >>
> >> This patch allows you to build the DTC source without making the
> >> tests directory.  This is necessary when cross compiling as the
> >> dumptest (and other) files cannot be run/used on the host system.
> >> To use this use: 'make TESTS='
> >
> > I think this is a silly way of doing this.  Instead create a new
> > target which builds everything but the tests.
> >
> > Say,
> >
> > 	all: cross tests
> >
> > 	cross: dtc ftdump libfdt
> 
> shouldn't we do this the other way around, it seems odd to build the  
> tests always or at least as part of the all target.

Hrm.  Yeah, I guess so.

The idea was to encourage the tests to be used as much as possible,
but I guess there's not all that much value to building them without
running them.

Patch forthcoming.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson