From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id C563FDDF1A for ; Wed, 12 Dec 2007 19:07:26 +1100 (EST) Subject: Re: [PATCH 1/2] Make setjmp/longjmp code generic From: Benjamin Herrenschmidt To: Kumar Gala In-Reply-To: References: <20071212054512.882AC62C070@localhost.localdomain> Content-Type: text/plain Date: Wed, 12 Dec 2007 19:06:54 +1100 Message-Id: <1197446814.8385.104.camel@pasglop> Mime-Version: 1.0 Cc: linuxppc-dev@ozlabs.org, Michael Neuling , RAISCH@de.ibm.com, Paul Mackerras , THEMANN@de.ibm.com Reply-To: benh@kernel.crashing.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 2007-12-12 at 01:59 -0600, Kumar Gala wrote: > On Dec 11, 2007, at 11:45 PM, Michael Neuling wrote: > > > This makes the setjmp/longjmp code used by xmon, generically available > > to other code. It also removes the requirement for debugger hooks to > > be only called on 0x300 (data storage) exception. > > > > Signed-off-by: Michael Neuling > > --- > > > > arch/powerpc/kernel/misc_64.S | 124 ++++++++++++++++++++++++++++++++ > > ++++++ > > arch/powerpc/mm/fault.c | 6 - > > arch/powerpc/xmon/Makefile | 2 > > arch/powerpc/xmon/setjmp.S | 135 > > ------------------------------------------ > > arch/powerpc/xmon/xmon.c | 10 --- > > include/asm-powerpc/setjmp.h | 12 +++ > > 6 files changed, 142 insertions(+), 147 deletions(-) > > it would seem that moving this code out of xmon.c into misc_64.s would > break ppc32 usage. Time to introduce a merged misc.S ? :-) Ben.